You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@xerces.apache.org by "Moti (JIRA)" <xe...@xml.apache.org> on 2016/11/19 19:21:58 UTC
[jira] [Commented] (XERCESC-2066) Exception handling mistake in
DTDScanner
[ https://issues.apache.org/jira/browse/XERCESC-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15679729#comment-15679729 ]
Moti commented on XERCESC-2066:
-------------------------------
Hi Scott,
You specified that the affected versions are 3.1.0, 3.1.1, 3.1.2, 3.1.3.
However, the NVD says (https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2016-2099) that all the versions below 3.1.3 are vulnerable to this (CVE-2016-2099) security issue.
I wanted to ask specifically for v2.7 whether it's vulnerable to it or not.
Can you put some light here?
Thanks!
> Exception handling mistake in DTDScanner
> ----------------------------------------
>
> Key: XERCESC-2066
> URL: https://issues.apache.org/jira/browse/XERCESC-2066
> Project: Xerces-C++
> Issue Type: Bug
> Components: Validating Parser (DTD)
> Affects Versions: 3.1.0, 3.1.1, 3.1.2, 3.1.3
> Reporter: Scott Cantor
> Assignee: Scott Cantor
> Fix For: 3.2.0, 3.1.4
>
>
> Index: src/xercesc/validators/DTD/DTDScanner.cpp
> ==========================================================The DTDScanner fails to account for the fact that peeking characters in the XMLReader class can raise an exception if an invalid character is encountered, and the exception crosses stack frames in an unsafe way that causes a higher level exception handler to access an already-freed object.
> The proposed patch below traps the exception locally and records the parser error in the appropriate frame.
> We should also review the code for other calls to the XMLReader methods that can throw.
> {code}
> --- src/xercesc/validators/DTD/DTDScanner.cpp (revision 1741478)
> +++ src/xercesc/validators/DTD/DTDScanner.cpp (working copy)
> @@ -2509,7 +2509,15 @@
> {
> while (true)
> {
> - const XMLCh nextCh = fReaderMgr->peekNextChar();
> + XMLCh nextCh;
> +
> + try {
> + nextCh = fReaderMgr->peekNextChar();
> + }
> + catch (XMLException& ex) {
> + fScanner->emitError(XMLErrs::XMLException_Fatal, ex.getCode(), ex.getMessage(), NULL, NULL);
> + nextCh = chNull;
> + }
>
> if (!nextCh)
> {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org