You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2021/06/25 15:33:38 UTC
[thrift] branch master updated: THRIFT-5436 Timeout.Infinite is not
a good default Client: netstd Patch: Jens Geyer
This is an automated email from the ASF dual-hosted git repository.
jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git
The following commit(s) were added to refs/heads/master by this push:
new 598ee98 THRIFT-5436 Timeout.Infinite is not a good default Client: netstd Patch: Jens Geyer
598ee98 is described below
commit 598ee9864beb51af18ee467e34340d4c9d462b6e
Author: Jens Geyer <je...@apache.org>
AuthorDate: Fri Jun 25 17:31:45 2021 +0200
THRIFT-5436 Timeout.Infinite is not a good default
Client: netstd
Patch: Jens Geyer
---
lib/netstd/Thrift/Transport/Client/TNamedPipeTransport.cs | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/netstd/Thrift/Transport/Client/TNamedPipeTransport.cs b/lib/netstd/Thrift/Transport/Client/TNamedPipeTransport.cs
index e6c79c4..c57db9d 100644
--- a/lib/netstd/Thrift/Transport/Client/TNamedPipeTransport.cs
+++ b/lib/netstd/Thrift/Transport/Client/TNamedPipeTransport.cs
@@ -28,17 +28,18 @@ namespace Thrift.Transport.Client
{
private NamedPipeClientStream PipeStream;
private readonly int ConnectTimeout;
+ private const int DEFAULT_CONNECT_TIMEOUT = 60 * 1000; // Timeout.Infinite is not a good default
- public TNamedPipeTransport(string pipe, TConfiguration config, int timeout = Timeout.Infinite)
+ public TNamedPipeTransport(string pipe, TConfiguration config, int timeout = DEFAULT_CONNECT_TIMEOUT)
: this(".", pipe, config, timeout)
{
}
- public TNamedPipeTransport(string server, string pipe, TConfiguration config, int timeout = Timeout.Infinite)
+ public TNamedPipeTransport(string server, string pipe, TConfiguration config, int timeout = DEFAULT_CONNECT_TIMEOUT)
: base(config)
{
var serverName = string.IsNullOrWhiteSpace(server) ? server : ".";
- ConnectTimeout = (timeout > 0) ? timeout : Timeout.Infinite;
+ ConnectTimeout = (timeout > 0) ? timeout : DEFAULT_CONNECT_TIMEOUT;
PipeStream = new NamedPipeClientStream(serverName, pipe, PipeDirection.InOut, PipeOptions.None, TokenImpersonationLevel.Anonymous);
}