You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2022/09/22 01:36:26 UTC
[kudu-CR] [docker] Update server flags
Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19027
Change subject: [docker] Update server flags
......................................................................
[docker] Update server flags
As a part of 27ac602108ab5e6b4e2211c2bfae3b36badc3121 we now need
to have the flag --unlock_unsafe_flags set to true when
--use_hybrid_clock is set to false.
Change-Id: I374413aec58b43170892fddc78d5539ebe244786
---
M docker/quickstart.yml
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/19027/1
--
To view, visit http://gerrit.cloudera.org:8080/19027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I374413aec58b43170892fddc78d5539ebe244786
Gerrit-Change-Number: 19027
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
[kudu-CR] [docker] Update server flags
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19027 )
Change subject: [docker] Update server flags
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19027/1/docker/quickstart.yml
File docker/quickstart.yml:
http://gerrit.cloudera.org:8080/#/c/19027/1/docker/quickstart.yml@40
PS1, Line 40:
missing ‘--unlock_unsafe_flags=true’ ?
--
To view, visit http://gerrit.cloudera.org:8080/19027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I374413aec58b43170892fddc78d5539ebe244786
Gerrit-Change-Number: 19027
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 02:39:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Update server flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19027 )
Change subject: [docker] Update server flags
......................................................................
[docker] Update server flags
As a part of 27ac602108ab5e6b4e2211c2bfae3b36badc3121 we now need
to have the flag --unlock_unsafe_flags set to true when
--use_hybrid_clock is set to false.
Change-Id: I374413aec58b43170892fddc78d5539ebe244786
Reviewed-on: http://gerrit.cloudera.org:8080/19027
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M docker/quickstart.yml
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I374413aec58b43170892fddc78d5539ebe244786
Gerrit-Change-Number: 19027
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [docker] Update server flags
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19027 )
Change subject: [docker] Update server flags
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19027/1/docker/quickstart.yml
File docker/quickstart.yml:
http://gerrit.cloudera.org:8080/#/c/19027/1/docker/quickstart.yml@40
PS1, Line 40:
> missing ‘--unlock_unsafe_flags=true’ ?
Thanks for the catch.
--
To view, visit http://gerrit.cloudera.org:8080/19027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I374413aec58b43170892fddc78d5539ebe244786
Gerrit-Change-Number: 19027
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 16:53:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Update server flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19027 )
Change subject: [docker] Update server flags
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Looks good to me
http://gerrit.cloudera.org:8080/#/c/19027/2/docker/quickstart.yml
File docker/quickstart.yml:
http://gerrit.cloudera.org:8080/#/c/19027/2/docker/quickstart.yml@39
PS2, Line 39: --use_hybrid_clock=false
: --unlock_unsafe_flags=true
An alternative for a cluster running at the same machine might be adding --time_source=system_unsync instead of adding these two flags.
But I guess that's just another story and should be addressed in a separate changelist (if addressed at all).
--
To view, visit http://gerrit.cloudera.org:8080/19027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I374413aec58b43170892fddc78d5539ebe244786
Gerrit-Change-Number: 19027
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 20:10:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docker] Update server flags
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19027 )
Change subject: [docker] Update server flags
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I374413aec58b43170892fddc78d5539ebe244786
Gerrit-Change-Number: 19027
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 22 Sep 2022 17:35:10 +0000
Gerrit-HasComments: No
[kudu-CR] [docker] Update server flags
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19027
to look at the new patch set (#2).
Change subject: [docker] Update server flags
......................................................................
[docker] Update server flags
As a part of 27ac602108ab5e6b4e2211c2bfae3b36badc3121 we now need
to have the flag --unlock_unsafe_flags set to true when
--use_hybrid_clock is set to false.
Change-Id: I374413aec58b43170892fddc78d5539ebe244786
---
M docker/quickstart.yml
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/19027/2
--
To view, visit http://gerrit.cloudera.org:8080/19027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I374413aec58b43170892fddc78d5539ebe244786
Gerrit-Change-Number: 19027
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>