You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailoale-db (via GitHub)" <gi...@apache.org> on 2026/05/26 23:19:09 UTC
[PR] [SPARK-57089] [SQL] Preserve collation name as `COLLATE` expression origin [spark]
mihailoale-db opened a new pull request, #56131:
URL: https://github.com/apache/spark/pull/56131
### What changes were proposed in this pull request?
In this issue I propose to preserve collation name as `COLLATE` expression origin. This would lead to better observability (e.g. for error messages).
### Why are the changes needed?
To improve `COLLATE` expression observability.
### Does this PR introduce _any_ user-facing change?
COLLATE expression origin improves.
### How was this patch tested?
Added + existing tests.
### Was this patch authored or co-authored using generative AI tooling?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57089] [SQL] Preserve collation name as `COLLATE` expression origin [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #56131:
URL: https://github.com/apache/spark/pull/56131#issuecomment-4557487322
thanks, merging to master/4.x!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57089] [SQL] Preserve collation name as `COLLATE` expression origin [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #56131: [SPARK-57089] [SQL] Preserve collation name as `COLLATE` expression origin
URL: https://github.com/apache/spark/pull/56131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57089] [SQL] Preserve collation name as `COLLATE` expression origin [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on PR #56131:
URL: https://github.com/apache/spark/pull/56131#issuecomment-4556873138
@cloud-fan PTAL when you find time. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org