[GitHub] [iceberg] flyrain commented on a change in pull request #3094: Core: Consolidate write.folder-storage.path and write.object-storage.path to write.data.path

[GitBox <gi...@apache.org>]

flyrain commented on a change in pull request #3094:
URL: https://github.com/apache/iceberg/pull/3094#discussion_r705810001



##########
File path: core/src/main/java/org/apache/iceberg/LocationProviders.java
##########
@@ -141,4 +133,18 @@ private static String stripTrailingSlash(String path) {
     }
     return result;
   }
+
+  public static String dataLocation(Map<String, String> properties, String tableLocation) {

Review comment:
       I make it public because it is used in IcebergSourceBenchmark.java. Maybe we can change `WRITE_FOLDER_STORAGE_LOCATION` to the `WRITE_DATA_PATH` in IcebergSourceBenchmark.java?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org