You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/31 06:58:54 UTC
[GitHub] [cloudstack] havengit opened a new pull request #4236: Update configure.py
havengit opened a new pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236
## Description
<!--- Describe your changes in detail -->
This PR resolves 1 issues Multiple Public Subnets static NAT issue
#3361 VR Issues with Multiple Public Subnets
The network has Multiple Public Subnets, enable a static NAT for VM with public IP, If the public IP subnets is different to default SNAT public IP subnets , the VM SNAT IP is default SNAT IP.
For example
In isolate network
Public IP:
192.168.3.3 netmask 255.255.255.0 (default source NAT IP)
192.168.4.3 netmask 255.255.255.0
VM IP:
10.10.1.100
Enable static NAT for 192.168.4.3 -->10.10.1.100
In VM ,get the public IP with commond : curl ip.sb
incorrect:
source nat is 192.168.3.3
correct:
source nat is 192.168.4.3
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#discussion_r492845742
##########
File path: systemvm/debian/opt/cloud/bin/configure.py
##########
@@ -964,6 +964,9 @@ def processStaticNatRule(self, rule):
self.fw.append(["mangle", "front",
"-A PREROUTING -d %s/32 -m state --state NEW -j MARK --set-xmark %s/0xffffffff" %
(rule["public_ip"], hex(100 + int(device[len("eth"):])))])
+ self.fw.append(["mangle", "front",
+ "-A PREROUTING -s %s/32 -m state --state NEW -i eth0 -j MARK --set-xmark %s/0xffffffff" %
Review comment:
@havengit @div8cn
I have tested this pr. The issue described in #3604 is not back.
However in this rule, it should not be "eth0".
for isolated network, the guest nic is eth0. but for vpc, eth0 is nic for link local ip.
```
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
link/ether 0e:00:a9:fe:65:77 brd ff:ff:ff:ff:ff:ff
inet 169.254.101.119/16 brd 169.254.255.255 scope global eth0
valid_lft forever preferred_lft forever
```
so in my point of view, this pr fixes the issue in isolated networks, but does not fix the issue in vpc. could you please confirm ? @havengit @div8cn
I have tested this pr but without "-i eth0", then issue #3604 is back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] havengit closed pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
havengit closed pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-714370779
@weizhouapache @rhtyd @andrijapanicsb, lgtm lgt-you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-673932517
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-673932000
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-714567636
see comment thread @DaanHoogland
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-714451053
> @weizhouapache @rhtyd @andrijapanicsb, lgtm lgt-you?
@DaanHoogland
niet goed :-D
see https://github.com/apache/cloudstack/pull/4236#discussion_r508433544
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-712863172
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-712790301
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#discussion_r493827347
##########
File path: systemvm/debian/opt/cloud/bin/configure.py
##########
@@ -964,6 +964,9 @@ def processStaticNatRule(self, rule):
self.fw.append(["mangle", "front",
"-A PREROUTING -d %s/32 -m state --state NEW -j MARK --set-xmark %s/0xffffffff" %
(rule["public_ip"], hex(100 + int(device[len("eth"):])))])
+ self.fw.append(["mangle", "front",
+ "-A PREROUTING -s %s/32 -m state --state NEW -i eth0 -j MARK --set-xmark %s/0xffffffff" %
Review comment:
ok, so we should be more intelligent about the IF to add in the rule, tnx @weizhouapache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-716537173
> > should we close this one?
> > @DaanHoogland hmmmm...
i'll take that as a nee
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-713538327
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-731240781
Looks like Wei has sent another PR that would handle some cases, @DaanHoogland @PaulAngus I'm not sure if this issue is handled well in Wei's new PR but given the objection let's move to next milestone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-694864874
@weizhouapache this would re-introduce the second removed rule from #3604 , only on another location. What is the consequence of the MARK, in your opinion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-671796826
kick travis in the
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-713723555
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-682424858
request for comments - @DaanHoogland @andrijapanicsb @PaulAngus
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-713060071
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] havengit commented on a change in pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
havengit commented on a change in pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#discussion_r528480021
##########
File path: systemvm/debian/opt/cloud/bin/configure.py
##########
@@ -964,6 +964,9 @@ def processStaticNatRule(self, rule):
self.fw.append(["mangle", "front",
"-A PREROUTING -d %s/32 -m state --state NEW -j MARK --set-xmark %s/0xffffffff" %
(rule["public_ip"], hex(100 + int(device[len("eth"):])))])
+ self.fw.append(["mangle", "front",
+ "-A PREROUTING -s %s/32 -m state --state NEW -i eth0 -j MARK --set-xmark %s/0xffffffff" %
Review comment:
@DaanHoogland yes, This PR only fixes the issue in isolated networks , Weizhou's PR was much more effective https://github.com/apache/cloudstack/pull/4484
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-713060071
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-667716654
as we have discussed, this issue is caused by commit 82d94a87c56e1414d155271cff2481175640bc20
we need to find a way to fix both this issue and the issue described in #3604.
maybe add public device name in the rules ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-716397114
> > > @weizhouapache @rhtyd @andrijapanicsb, lgtm lgt-you?
> >
> >
> > @DaanHoogland
> > niet goed :-D
> > see [#4236 (comment)](https://github.com/apache/cloudstack/pull/4236#discussion_r508433544)
>
> ok, @weizhouapache I didn't get it, just to verify, this solves it for isolated networks but we don't accept it because the issue remains for VPCs, right?
@DaanHoogland yes, the issue still remains for VPCs.
> should we close this one?
@DaanHoogland hmmmm...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-714684229
> > @weizhouapache @rhtyd @andrijapanicsb, lgtm lgt-you?
>
> @DaanHoogland
> niet goed :-D
> see [#4236 (comment)](https://github.com/apache/cloudstack/pull/4236#discussion_r508433544)
ok, @weizhouapache I didn't get it, just to verify, this solves it for isolated networks but we don't accept it because the issue remains for VPCs, right?
should we close this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#discussion_r508433544
##########
File path: systemvm/debian/opt/cloud/bin/configure.py
##########
@@ -964,6 +964,9 @@ def processStaticNatRule(self, rule):
self.fw.append(["mangle", "front",
"-A PREROUTING -d %s/32 -m state --state NEW -j MARK --set-xmark %s/0xffffffff" %
(rule["public_ip"], hex(100 + int(device[len("eth"):])))])
+ self.fw.append(["mangle", "front",
+ "-A PREROUTING -s %s/32 -m state --state NEW -i eth0 -j MARK --set-xmark %s/0xffffffff" %
Review comment:
@DaanHoogland I have confirmed with @div8cn that the issue still exist with vpc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-713060380
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-673966651
as I said , this might cause the issue in #3604
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-727826733
@PaulAngus as per @weizhouapache 's comment, this has a 👎 . He is working on a more solid fix as far as I understand. If you want to RC this week, this should go to 4.15.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-673955965
Packaging result: ✔centos7 ✔debian. JID-1750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-712790723
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-713538327
<b>Trillian test result (tid-3028)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 62718 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4236-t3028-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 21 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
test_01_sys_vm_start | `Failure` | 0.10 | test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.16 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.05 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.04 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.04 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.04 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.47 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.46 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.46 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.47 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.26 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.30 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 17.19 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.36 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 74.02 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.25 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.87 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1513.49 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#discussion_r492845742
##########
File path: systemvm/debian/opt/cloud/bin/configure.py
##########
@@ -964,6 +964,9 @@ def processStaticNatRule(self, rule):
self.fw.append(["mangle", "front",
"-A PREROUTING -d %s/32 -m state --state NEW -j MARK --set-xmark %s/0xffffffff" %
(rule["public_ip"], hex(100 + int(device[len("eth"):])))])
+ self.fw.append(["mangle", "front",
+ "-A PREROUTING -s %s/32 -m state --state NEW -i eth0 -j MARK --set-xmark %s/0xffffffff" %
Review comment:
@havengit @div8cn
I have tested this pr. The issue described in #3604 is not back.
However in this rule, it should not be "eth0".
for isolated network, the guest nic is eth0. but for vpc, eth0 is nic for link local ip.
```
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP group default qlen 1000
link/ether 0e:00:a9:fe:65:77 brd ff:ff:ff:ff:ff:ff
inet 169.254.101.119/16 brd 169.254.255.255 scope global eth0
valid_lft forever preferred_lft forever
```
so in my point of view, this pr fixes the issue in isolated networks, but does not fix the issue in vpc. could you please confirm ? @havengit @div8cn
I have tested this pr but without "-i eth0", then issue #3604 is back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-713724076
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-669196113
should we add
Fixes #4234
to the description of this PR, @havengit ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-714180516
<b>Trillian test result (tid-3041)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31439 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4236-t3041-kvm-centos7.zip
Smoke tests completed. 85 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] havengit commented on pull request #4236: resolves issues Multiple Public Subnets static NAT
Posted by GitBox <gi...@apache.org>.
havengit commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-731954419
Weizhou's PR was much more effective #4484
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org