You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Andrew.D.lin (Jira)" <ji...@apache.org> on 2020/01/14 01:13:00 UTC

[jira] [Commented] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

    [ https://issues.apache.org/jira/browse/FLINK-15307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014771#comment-17014771 ] 

Andrew.D.lin commented on FLINK-15307:
--------------------------------------

Hi [~zhuzh] 

I open the PR: [https://github.com/apache/flink/pull/10848, :D|https://github.com/apache/flink/pull/10848]

 

> Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy
> -------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-15307
>                 URL: https://issues.apache.org/jira/browse/FLINK-15307
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Configuration
>            Reporter: Andrew.D.lin
>            Assignee: Andrew.D.lin
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>         Attachments: image-2019-12-18-14-59-03-181.png
>
>          Time Spent: 10m
>  Remaining Estimate: 24h
>
> Subclasses of RestartStrategy
>  * FailingRestartStrategy
>  * FailureRateRestartStrategy
>  * FixedDelayRestartStrategy
>  * InfiniteDelayRestartStrategy
> Implementation class of FailoverStrategy
>  * AdaptedRestartPipelinedRegionStrategyNG
>  * RestartAllStrategy
>  * RestartIndividualStrategy
>  * RestartPipelinedRegionStrategy
>  
> FailoverStrategy describes how the job computation recovers from task failures.
> I think the following names may be easier to understand and easier to distinguish:
> Implementation class of FailoverStrategy
>  * AdaptedPipelinedRegionFailoverStrategyNG
>  * FailoverAllStrategy
>  * FailoverIndividualStrategy
>  * FailoverPipelinedRegionStrategy
> FailoverStrategy is currently generated by configuration. If we change the name of the implementation class, it will not affect compatibility.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)