[GitHub] [kafka] chia7712 commented on a change in pull request #9735: KAFKA-10846: Grow buffer in FileSourceStreamTask only when needed

[GitBox <gi...@apache.org>]

chia7712 commented on a change in pull request #9735:
URL: https://github.com/apache/kafka/pull/9735#discussion_r545179120



##########
File path: connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
##########
@@ -77,6 +78,17 @@ private void replay() {
 
     @Test
     public void testNormalLifecycle() throws InterruptedException, IOException {
+        normalLifecycle();
+    }
+
+    @Test
+    public void testNormalLifecycleWithResize() throws InterruptedException, IOException {
+        task = new FileStreamSourceTask(2);

Review comment:
       This new test case LGTM. However, it re-create the task. How about setting a small initial size of FileStreamSourceTask to make all test cases meet the resize?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org