You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2019/02/08 18:25:15 UTC

[GitHub] [geode] kirklund opened pull request #3177: GEODE-6033: Make DistributedDiskDirRule support create and bounce VM

Two commits:
```
commit c21b29df34888418644fffd1655e670dd23b9a2b
Author: Kirk Lund <kl...@apache.org>
Date:   Fri Feb 8 10:22:43 2019 -0800

    GEODE-6033: Make DistributedDiskDirRule support create and bounce VM
```
```
commit e5363e26dcf8a607eee0f8d274986f25d5fb4ddd
Author: Kirk Lund <kl...@apache.org>
Date:   Thu Feb 7 16:03:24 2019 -0800

    GEODE-6033: Create tests for DiskDirRule
    
    Fix a couple minor issues found by testing DiskDirRule.
```

[ Full content available at: https://github.com/apache/geode/pull/3177 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #3177: GEODE-6033: Support dynamic VMs in DistributedDiskDirRule

Posted by "kirklund (GitHub)" <gi...@apache.org>.

[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/3177 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #3177: GEODE-6033: Support dynamic VMs in DistributedDiskDirRule

Posted by "kirklund (GitHub)" <gi...@apache.org>.

The failure in DistributedAckRegionOffHeapDUnitTest.testNBRegionDestructionDuringGetInitialImage appears to be caused by:
```
commit bfc0449e81b7ac5429f7473b216762c22c10f95b
Author: Xiaojian Zhou <ge...@users.noreply.github.com>
Date:   Wed Feb 6 17:14:34 2019 -0800

    GEODE-6277: use await() instead of hard-coded sleep(3000) in the test (#3086)
```

[ Full content available at: https://github.com/apache/geode/pull/3177 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] moleske commented on pull request #3177: GEODE-6033: Support dynamic VMs in DistributedDiskDirRule

Posted by "moleske (GitHub)" <gi...@apache.org>.

Just because I want to double check, is there need for `toArray`?  I probably would have used for each with the list unless there's a significant performance bonus

```java
List<VM> allVMs = getAllVMs();
allVMs.add(getController());
for (VM vm : allVMs) {
    ...
}
```

[ Full content available at: https://github.com/apache/geode/pull/3177 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org