You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/11/11 17:53:02 UTC
Re: Review Request 27503: Moved Clock implementation into clock.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27503/
-----------------------------------------------------------
(Updated Nov. 11, 2014, 4:53 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/Makefile.am a55d5620d34fcd483459155c5f66aa0e5b2b7c68
3rdparty/libprocess/src/clock.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
Diff: https://reviews.apache.org/r/27503/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 27503: Moved Clock implementation into clock.cpp.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27503/#review61594
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Nov. 14, 2014, 3:17 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27503/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 3:17 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am a55d5620d34fcd483459155c5f66aa0e5b2b7c68
> 3rdparty/libprocess/src/clock.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 5842705ae78ebe36c1c01bfcd468e9ebe55de3be
>
> Diff: https://reviews.apache.org/r/27503/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 27503: Moved Clock implementation into clock.cpp.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27503/
-----------------------------------------------------------
(Updated Nov. 14, 2014, 11:17 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am a55d5620d34fcd483459155c5f66aa0e5b2b7c68
3rdparty/libprocess/src/clock.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 5842705ae78ebe36c1c01bfcd468e9ebe55de3be
Diff: https://reviews.apache.org/r/27503/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 27503: Moved Clock implementation into clock.cpp.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Nov. 11, 2014, 11:18 p.m., Niklas Nielsen wrote:
> > 3rdparty/libprocess/src/clock.cpp, line 424
> > <https://reviews.apache.org/r/27503/diff/1/?file=747113#file747113line424>
> >
> > How about a Clock::time(seconds) factory instead? Like the refactor you did for Timer?
Great idea! I implemented a TODO for now.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27503/#review60880
-----------------------------------------------------------
On Nov. 11, 2014, 4:53 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27503/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2014, 4:53 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am a55d5620d34fcd483459155c5f66aa0e5b2b7c68
> 3rdparty/libprocess/src/clock.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
>
> Diff: https://reviews.apache.org/r/27503/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 27503: Moved Clock implementation into clock.cpp.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27503/#review60880
-----------------------------------------------------------
3rdparty/libprocess/src/clock.cpp
<https://reviews.apache.org/r/27503/#comment102289>
How about a Clock::time(seconds) factory instead? Like the refactor you did for Timer?
- Niklas Nielsen
On Nov. 11, 2014, 8:53 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27503/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2014, 8:53 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am a55d5620d34fcd483459155c5f66aa0e5b2b7c68
> 3rdparty/libprocess/src/clock.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 85fb9958342f0bcdde322d9c55333126e6f86668
>
> Diff: https://reviews.apache.org/r/27503/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>