You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sachchidanand Vaidya <va...@juniper.net> on 2014/05/03 09:29:30 UTC
Re: Review Request 19270: Added service-instance delete command to Juniper
Contrail Plugin and related fixes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19270/
-----------------------------------------------------------
(Updated May 3, 2014, 12:29 a.m.)
Review request for cloudstack and Rajesh Battala.
Changes
-------
.
Repository: cloudstack-git
Description
-------
This patch has following changes:
- Added service-instance delete command to Juniper Contrail Plugin.
- Fixes to plugin code to handle instance-delete operation properly.
- Fix related to service-instance persistence and re-creation during Mgmt server reboot.
Diffs
-----
client/tomcatconf/commands.properties.in 45debe4
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c
Diff: https://reviews.apache.org/r/19270/diff/
Testing
-------
Unit tests passed and additional testing done locally.
Thanks,
Sachchidanand Vaidya
Re: Review Request 19270: Added service-instance delete command to Juniper
Contrail Plugin and related fixes
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19270/#review45197
-----------------------------------------------------------
Looks good to me.
I didn't fine unittests for the new commands and functionality added.
community wont push new features without UnitTests/Marvin tests.
what about documentation of these features?
- Rajesh Battala
On May 7, 2014, 10:44 p.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19270/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 10:44 p.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch has following changes:
> - Added service-instance delete command to Juniper Contrail Plugin.
> - Fixes to plugin code to handle instance-delete operation properly.
> - Fix related to service-instance persistence and re-creation during Mgmt server reboot.
>
>
> Diffs
> -----
>
> api/src/com/cloud/event/EventTypes.java 075b1c8
> client/tomcatconf/commands.properties.in d3a24f6
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java 59c4e61
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c
>
> Diff: https://reviews.apache.org/r/19270/diff/
>
>
> Testing
> -------
>
> Unit tests passed and additional testing done locally.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>
Re: Review Request 19270: Added service-instance delete command to
Juniper Contrail Plugin and related fixes
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19270/#review79047
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On May 7, 2014, 10:44 p.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19270/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 10:44 p.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch has following changes:
> - Added service-instance delete command to Juniper Contrail Plugin.
> - Fixes to plugin code to handle instance-delete operation properly.
> - Fix related to service-instance persistence and re-creation during Mgmt server reboot.
>
>
> Diffs
> -----
>
> api/src/com/cloud/event/EventTypes.java 075b1c8
> client/tomcatconf/commands.properties.in d3a24f6
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java 59c4e61
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c
>
> Diff: https://reviews.apache.org/r/19270/diff/
>
>
> Testing
> -------
>
> Unit tests passed and additional testing done locally.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>
Re: Review Request 19270: Added service-instance delete command to
Juniper Contrail Plugin and related fixes
Posted by Sachchidanand Vaidya <va...@juniper.net>.
Hi Rajesh,
Can you pls review the updated diff.
Thanks,
Sachin
On 5/7/14 3:44 PM, "Sachchidanand Vaidya" <va...@juniper.net> wrote:
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/19270/
>-----------------------------------------------------------
>
>(Updated May 7, 2014, 3:44 p.m.)
>
>
>Review request for cloudstack and Rajesh Battala.
>
>
>Changes
>-------
>
>Fixed licenser header and created new EventTypes for serviceInstance VM
>create and delete.
>
>Thanks,
>Sachin
>
>
>Repository: cloudstack-git
>
>
>Description
>-------
>
>This patch has following changes:
> - Added service-instance delete command to Juniper Contrail Plugin.
> - Fixes to plugin code to handle instance-delete operation properly.
> - Fix related to service-instance persistence and re-creation during
>Mgmt server reboot.
>
>
>Diffs (updated)
>-----
>
> api/src/com/cloud/event/EventTypes.java 075b1c8
> client/tomcatconf/commands.properties.in d3a24f6
>
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/api/command/CreateServiceInstanceCmd.java 59c4e61
>
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION
>
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/management/ContrailElementImpl.java 05723b0
>
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/management/ContrailGuru.java f81c0d0
>
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/management/ServerDBSyncImpl.java b9a3ed3
>
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/management/ServiceManager.java e4ef26d
>
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/management/ServiceManagerImpl.java f34eacc
>
>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ
>k/contrail/model/ServiceInstanceModel.java e79053c
>
>Diff: https://reviews.apache.org/r/19270/diff/
>
>
>Testing
>-------
>
>Unit tests passed and additional testing done locally.
>
>
>Thanks,
>
>Sachchidanand Vaidya
>
Re: Review Request 19270: Added service-instance delete command to Juniper
Contrail Plugin and related fixes
Posted by Sachchidanand Vaidya <va...@juniper.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19270/
-----------------------------------------------------------
(Updated May 7, 2014, 3:44 p.m.)
Review request for cloudstack and Rajesh Battala.
Changes
-------
Fixed licenser header and created new EventTypes for serviceInstance VM create and delete.
Thanks,
Sachin
Repository: cloudstack-git
Description
-------
This patch has following changes:
- Added service-instance delete command to Juniper Contrail Plugin.
- Fixes to plugin code to handle instance-delete operation properly.
- Fix related to service-instance persistence and re-creation during Mgmt server reboot.
Diffs (updated)
-----
api/src/com/cloud/event/EventTypes.java 075b1c8
client/tomcatconf/commands.properties.in d3a24f6
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java 59c4e61
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c
Diff: https://reviews.apache.org/r/19270/diff/
Testing
-------
Unit tests passed and additional testing done locally.
Thanks,
Sachchidanand Vaidya
Re: Review Request 19270: Added service-instance delete command to Juniper
Contrail Plugin and related fixes
Posted by Sachchidanand Vaidya <va...@juniper.net>.
> On May 5, 2014, 11:32 p.m., Rajesh Battala wrote:
> > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java, line 40
> > <https://reviews.apache.org/r/19270/diff/1/?file=521583#file521583line40>
> >
> > As the service vm is specific to juniper-contrail, instead of using vm_destroy create an specific event type. refer EVENT_INTERNAL_LB_VM_STOP/START
Added separete EVENTs for service instance VM creation and destroy.
- Sachchidanand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19270/#review42253
-----------------------------------------------------------
On May 7, 2014, 3:44 p.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19270/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 3:44 p.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch has following changes:
> - Added service-instance delete command to Juniper Contrail Plugin.
> - Fixes to plugin code to handle instance-delete operation properly.
> - Fix related to service-instance persistence and re-creation during Mgmt server reboot.
>
>
> Diffs
> -----
>
> api/src/com/cloud/event/EventTypes.java 075b1c8
> client/tomcatconf/commands.properties.in d3a24f6
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java 59c4e61
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c
>
> Diff: https://reviews.apache.org/r/19270/diff/
>
>
> Testing
> -------
>
> Unit tests passed and additional testing done locally.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>
Re: Review Request 19270: Added service-instance delete command to Juniper
Contrail Plugin and related fixes
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19270/#review42253
-----------------------------------------------------------
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java
<https://reviews.apache.org/r/19270/#comment76044>
As the service vm is specific to juniper-contrail, instead of using vm_destroy create an specific event type. refer EVENT_INTERNAL_LB_VM_STOP/START
- Rajesh Battala
On May 3, 2014, 7:29 a.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19270/
> -----------------------------------------------------------
>
> (Updated May 3, 2014, 7:29 a.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch has following changes:
> - Added service-instance delete command to Juniper Contrail Plugin.
> - Fixes to plugin code to handle instance-delete operation properly.
> - Fix related to service-instance persistence and re-creation during Mgmt server reboot.
>
>
> Diffs
> -----
>
> client/tomcatconf/commands.properties.in 45debe4
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c
>
> Diff: https://reviews.apache.org/r/19270/diff/
>
>
> Testing
> -------
>
> Unit tests passed and additional testing done locally.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>
Re: Review Request 19270: Added service-instance delete command to Juniper
Contrail Plugin and related fixes
Posted by Sachchidanand Vaidya <va...@juniper.net>.
> On May 5, 2014, 11:38 p.m., Rajesh Battala wrote:
> > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java, line 1
> > <https://reviews.apache.org/r/19270/diff/1/?file=521583#file521583line1>
> >
> > No license header
> > after adding license header, please run rat command to check for license
Ran rat and fixed license header
- Sachchidanand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19270/#review42254
-----------------------------------------------------------
On May 7, 2014, 3:44 p.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19270/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 3:44 p.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch has following changes:
> - Added service-instance delete command to Juniper Contrail Plugin.
> - Fixes to plugin code to handle instance-delete operation properly.
> - Fix related to service-instance persistence and re-creation during Mgmt server reboot.
>
>
> Diffs
> -----
>
> api/src/com/cloud/event/EventTypes.java 075b1c8
> client/tomcatconf/commands.properties.in d3a24f6
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java 59c4e61
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c
>
> Diff: https://reviews.apache.org/r/19270/diff/
>
>
> Testing
> -------
>
> Unit tests passed and additional testing done locally.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>
Re: Review Request 19270: Added service-instance delete command to Juniper
Contrail Plugin and related fixes
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19270/#review42254
-----------------------------------------------------------
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java
<https://reviews.apache.org/r/19270/#comment76045>
No license header
after adding license header, please run rat command to check for license
- Rajesh Battala
On May 3, 2014, 7:29 a.m., Sachchidanand Vaidya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19270/
> -----------------------------------------------------------
>
> (Updated May 3, 2014, 7:29 a.m.)
>
>
> Review request for cloudstack and Rajesh Battala.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This patch has following changes:
> - Added service-instance delete command to Juniper Contrail Plugin.
> - Fixes to plugin code to handle instance-delete operation properly.
> - Fix related to service-instance persistence and re-creation during Mgmt server reboot.
>
>
> Diffs
> -----
>
> client/tomcatconf/commands.properties.in 45debe4
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c
>
> Diff: https://reviews.apache.org/r/19270/diff/
>
>
> Testing
> -------
>
> Unit tests passed and additional testing done locally.
>
>
> Thanks,
>
> Sachchidanand Vaidya
>
>