[GitHub] [ignite-3] vladErmakov07 commented on a change in pull request #606: IGNITE-16422 Table API fix

[GitBox <gi...@apache.org>]

vladErmakov07 commented on a change in pull request #606:
URL: https://github.com/apache/ignite-3/pull/606#discussion_r795484813



##########
File path: modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/IgniteTableImpl.java
##########
@@ -303,39 +305,26 @@ public void removeIndex(String idxName) {
     }
 
     private <RowT> BinaryRow updateTuple(RowT row, List<String> updateColList, ExecutionContext<RowT> ectx) {
-        int nonNullVarlenKeyCols = 0;

Review comment:
       Apparently, in this method we were calculating the number of keys and values changed. Based on this numbers, we create rowAssembler. 
   But, further, we set a value for every column in the schema. (for (ColumnDescriptor colDesc : columnsOrderedByPhysSchema)) 
   In case we changed only part of the columns, we get an internal RowAssembler exception.
   
   This is my understanding at this point. Please pay attention to this part during the review.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org