You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2012/06/11 13:39:43 UTC
[jira] [Created] (CAMEL-5357) URI normalization - Should detect
already percent encoded values
Claus Ibsen created CAMEL-5357:
----------------------------------
Summary: URI normalization - Should detect already percent encoded values
Key: CAMEL-5357
URL: https://issues.apache.org/jira/browse/CAMEL-5357
Project: Camel
Issue Type: Bug
Components: camel-core
Reporter: Claus Ibsen
Assignee: Claus Ibsen
If an uri has a percent encoded value, eg using %20, %25 etc, then the normalization logic in Camel should detect this and keep the value as is.
Currently it would end up double encoding %25, that becomes %2525, and so forth.
Its the code in UnsafeUriCharactersEncoder that has the bug
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5357) URI normalization - Should detect
already percent encoded values
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293432#comment-13293432 ]
Claus Ibsen commented on CAMEL-5357:
------------------------------------
Now we detect the % sign and only encodes if it needs to be, eg not already encoded, eg if you have %20, %25 etc. Then thats already encoded.
There is some good details about url encode from wikipedia
http://en.wikipedia.org/wiki/Url_encode
> URI normalization - Should detect already percent encoded values
> ----------------------------------------------------------------
>
> Key: CAMEL-5357
> URL: https://issues.apache.org/jira/browse/CAMEL-5357
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
>
> If an uri has a percent encoded value, eg using %20, %25 etc, then the normalization logic in Camel should detect this and keep the value as is.
> Currently it would end up double encoding %25, that becomes %2525, and so forth.
> Its the code in UnsafeUriCharactersEncoder that has the bug
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-5357) URI normalization - Should detect
already percent encoded values
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-5357.
--------------------------------
Resolution: Fixed
Fix Version/s: 2.10.0
> URI normalization - Should detect already percent encoded values
> ----------------------------------------------------------------
>
> Key: CAMEL-5357
> URL: https://issues.apache.org/jira/browse/CAMEL-5357
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 2.10.0
>
>
> If an uri has a percent encoded value, eg using %20, %25 etc, then the normalization logic in Camel should detect this and keep the value as is.
> Currently it would end up double encoding %25, that becomes %2525, and so forth.
> Its the code in UnsafeUriCharactersEncoder that has the bug
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5357) URI normalization - Should detect
already percent encoded values
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293448#comment-13293448 ]
Claus Ibsen commented on CAMEL-5357:
------------------------------------
This bug has been partly fixed by CAMEL-4425, but failed to encode % itself to %25.
Albeit using the % sign is seldom used. However can be used by the SQL component.
So the fix is to detect the % sign and check if its already decimal encoded or not.
> URI normalization - Should detect already percent encoded values
> ----------------------------------------------------------------
>
> Key: CAMEL-5357
> URL: https://issues.apache.org/jira/browse/CAMEL-5357
> Project: Camel
> Issue Type: Bug
> Components: camel-core
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
>
> If an uri has a percent encoded value, eg using %20, %25 etc, then the normalization logic in Camel should detect this and keep the value as is.
> Currently it would end up double encoding %25, that becomes %2525, and so forth.
> Its the code in UnsafeUriCharactersEncoder that has the bug
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira