You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2018/01/16 09:02:06 UTC

[GitHub] flink pull request #5281: [FLINK-7938] [State Backend] support addAll() in L...

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5281#discussion_r161693211
  
    --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java ---
    @@ -756,6 +756,11 @@ public boolean isClearCalled() {
     		public void update(List<T> values) throws Exception {
     			clear();
     
    +			addAll(values);
    +		}
    +
    +		@Override
    +		public void addAll(List<T> values) throws Exception {
     			if (values != null && !values.isEmpty()) {
    --- End diff --
    
    I think the check for `!values.isEmpty()` is not required and just boilerplate - the following line also works for empty lists.


---