You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/11/14 10:02:31 UTC

[GitHub] [geode] gaussianrecurrence opened a new pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

gaussianrecurrence opened a new pull request #5751:
URL: https://github.com/apache/geode/pull/5751


    - If while calling DistributionImpl.start there was either a
      MembershipConfigurationException or MemberStartupException exceptions, its
      original cause was not propagated, therefore being unable to properly tackle
      issues on startup.
    - This commit propagates both exceptions.
    - Also 2 junit test were added to make sure this is working.
    - Also 2 DUnit tests were modified in order to integrate with this
      change.
   
   Note: After having to revert the original change in PR #5725 due to some
         issues with the CI system, test have been sorted out and everything
         is working.
   
   ---
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] kohlmu-pivotal edited a comment on pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal edited a comment on pull request #5751:
URL: https://github.com/apache/geode/pull/5751#issuecomment-730081544


   > I think this violates the intent that `membership` exceptions should not escape the module
   
   @echobravopapa I love the idea that modules/components don't leak anything outside of itself. But if looking at the `DistribtionImpl` the exceptions that you don't want to leak "out", have already leaked into geode-core. So, not sure how we are trying to stop the leaking.
   
   It is not like there is even a violation of public -> internal package namespaces. The usage are in 2 internal packages.
   
   If the intent that exceptions do not escape the module, then the current implementation needs to be addressed. As the current implementation is a sieve. The exceptions have already leaked out!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] kohlmu-pivotal commented on pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal commented on pull request #5751:
URL: https://github.com/apache/geode/pull/5751#issuecomment-730567727


   @gaussianrecurrence Would it be possible for the you to reproduce the issue that  you are seeing (and trying to fix) and update the JIRA with this information?
   
   That will hopefully give the reviewers some context as to WHAT exactly you are trying to fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] gaussianrecurrence commented on pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

Posted by GitBox <gi...@apache.org>.
gaussianrecurrence commented on pull request #5751:
URL: https://github.com/apache/geode/pull/5751#issuecomment-730572491


   Sorry @kohlmu-pivotal and @echobravopapa but I have been quite busy these days.
   The rationale behind this change is described already in the Jira description, probably with not too much detail.
   But quickly summarizing, while starting a locator if there is an exception having to do with JGroups, the cause is not included in the top exception, hence loosing the context on what's happening. Hopefully this clarifies the intention of this fix.
   
   Regarding about whether or not to leak the exception, I don't have an strong point as Java is not my main language. But for what I can tell, there are these exceptions which are internal and we wouldn't want these to be exposed, that's why they are being wrapper as SystemConnectException and GemFireConfigException. If that's the case I don't have any problem with that, 
   
   Still,  unless I am missing something important here, what I believe is that the exception cause should be there, otherwise troubleshooting these kind of issues could be a real pain.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] bschuchardt commented on pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

Posted by GitBox <gi...@apache.org>.
bschuchardt commented on pull request #5751:
URL: https://github.com/apache/geode/pull/5751#issuecomment-735939753


   Don't forget to resolve the JIRA ticket


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] kohlmu-pivotal commented on pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal commented on pull request #5751:
URL: https://github.com/apache/geode/pull/5751#issuecomment-730081544


   > I think this violates the intent that `membership` exceptions should not escape the module
   
   @echobravopapa I love the idea that modules/components don't leak anything outside of itself. But if looking at the `DistribtionImpl` the exceptions that you don't want to leak "out", have already leaked into geode-core. So, not sure how we are trying to stop the leaking.
   
   It is not like there is even a violation of public -> internal package. The usage are in 2 internal classes.
   
   If the intent that exceptions do not escape the module, then the current implementation needs to be addressed. As the current implementation is a sieve. The exceptions have already leaked out!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] kohlmu-pivotal edited a comment on pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal edited a comment on pull request #5751:
URL: https://github.com/apache/geode/pull/5751#issuecomment-730082165


   > I think this violates the intent that `membership` exceptions should not escape the module
   
   @echobravopapa if the intent is not for the exceptions leaking out, could you possibly suggest alternate implementations on how to resolve the issue that @gaussianrecurrence has raised?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] echobravopapa commented on pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

Posted by GitBox <gi...@apache.org>.
echobravopapa commented on pull request #5751:
URL: https://github.com/apache/geode/pull/5751#issuecomment-730521501


   it's unclear what the actual issue this change is fixing...  here is an example of a recent bug we fixed caused by exceptions escaping... https://issues.apache.org/jira/browse/GEODE-8697


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] bschuchardt merged pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

Posted by GitBox <gi...@apache.org>.
bschuchardt merged pull request #5751:
URL: https://github.com/apache/geode/pull/5751


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode] kohlmu-pivotal commented on pull request #5751: GEODE-8664: Nest errors in DistributionImpl.start

Posted by GitBox <gi...@apache.org>.
kohlmu-pivotal commented on pull request #5751:
URL: https://github.com/apache/geode/pull/5751#issuecomment-730082165


   > I think this violates the intent that `membership` exceptions should not escape the module
   
   @echobravopapa if the intent is not for the exceptions leaking out, could you possibly suggest an alternate implementations on how to resolve the issue that @gaussianrecurrence has raised?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org