[GitHub] [hudi] codope commented on a diff in pull request #5274: [HUDI-3839] Fixing incorrect selection of MT partitions to be updated

[GitBox <gi...@apache.org>]

codope commented on code in PR #5274:
URL: https://github.com/apache/hudi/pull/5274#discussion_r846953930


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -770,18 +774,6 @@ private MetadataRecordsGenerationParams getRecordsGenerationParams() {
     }
   }
 
-  private Set<String> getMetadataPartitionsToUpdate() {

Review Comment:
   @alexeykudinkin The motivation behind the change was that the table config should be the source of truth for what partitions are available for update or reads. Case 3 is a valid one. Note that even if an MDT partition is inflight (by async indexer), it must have already been initialized and hence ready to accept updates. You mentioned
   > it will not update files partition if Column Stats is enabled.
   
   Can you explain the scenario when this happened? From my understanding and testing, files partition should already be present in the table config because the files partition is initialized synchronously with the initialization of metadata writer. Perhaps, we're missing some corner case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org