You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/28 04:01:19 UTC

[GitHub] [incubator-nuttx] donghengqaz opened a new pull request #1908: arch/xtesna: Fix task signal process preemption A0 modification error

donghengqaz opened a new pull request #1908:
URL: https://github.com/apache/incubator-nuttx/pull/1908


   ## Summary
   
   Fix task signal process preemption A0 modification error.
   
   ## Impact
   
   Fix issue:
   
   Task1 --> process
         --> xtensa_context_save(S1)
         --> s32i a0, a2, (4 * REG_A0)
         --> rtcb->xcp.regs[REG_A0] = A0
   
   Task preemption
   
   ```c
   Task2 --> Post signal to Task1
         --> Wake up Task1
   
   Task1 --> xtensa_sig_deliver
         --> up_irq_enable()
         --> Task preemption
   
   Task preemption --> xtensa_context_save
                   --> rtcb->xcp.regs[REG_A0] = A0 of "xtensa_sig_deliver"
                       = _xtensa_sig_trampoline + 6
                       = "j 1b"
   
   Process ...
   
   Task1 --> xtensa_sig_deliver
         --> xtensa_context_restore
         --> xtensa_context_save(S1)
         --> l32i a0, a2, (4 * REG_A0)
         --> a0 = "j 1b"
         --> ret
         --> run "j 1b"
   ```
   
   ## Testing
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] donghengqaz commented on pull request #1908: arch/xtesna: Fix task signal process preemption A0 modification error

Posted by GitBox <gi...@apache.org>.
donghengqaz commented on pull request #1908:
URL: https://github.com/apache/incubator-nuttx/pull/1908#issuecomment-699757015


   @acassis @Ouss4 @v01d @patacongo @xiaoxiang781216 @btashton @liuguo09 This in an important fix for complex application of ESP32. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] donghengqaz commented on pull request #1908: arch/xtensa: Fix task signal process preemption A0 modification error

Posted by GitBox <gi...@apache.org>.
donghengqaz commented on pull request #1908:
URL: https://github.com/apache/incubator-nuttx/pull/1908#issuecomment-700386123


   > Hi @donghengqaz how to exercise this issue? Does this issue manifest when running the "ostest"
   
   I use the ESP32 WiFi + WAPI to exercise this issue, I have not tested the "ostest". Because the WiFi driver will run the LP work queue frequently. You can try this with config WAPI also.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #1908: arch/xtensa: Fix task signal process preemption A0 modification error

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1908:
URL: https://github.com/apache/incubator-nuttx/pull/1908#issuecomment-699967801


   Hi @donghengqaz how to exercise this issue? Does this issue manifest when running the "ostest" ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #1908: arch/xtensa: Fix task signal process preemption A0 modification error

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1908:
URL: https://github.com/apache/incubator-nuttx/pull/1908


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org