Re: [PR] Reject vowels in SedolCheckDigit [commons-validator]

["sahvx655-wq (via GitHub)" <gi...@apache.org>]

sahvx655-wq commented on PR #415:
URL: https://github.com/apache/commons-validator/pull/415#issuecomment-4880692993

   Makes sense. Switched testVowelsRejected to a @ParameterizedTest driven by @ValueSource and dropped the loop. Added a fixture per vowel that isolates it: A000000, E000006, I000002, O000006 and U000000, each a single vowel in the body with a correct modulus 10 check digit, so they only fail once the vowel exclusion is applied rather than on a check-digit mismatch. The earlier multi-vowel codes (B0AKT02, 0EIOU02, BAEIOU7, AAAAAA0) are kept as further fixtures.
   
   Each row now runs as its own invocation, so a regression on one particular vowel points straight at that vowel instead of failing the whole loop. Full build stays green.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org