You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/12/20 19:45:45 UTC

[GitHub] [lucene] dweiss commented on a change in pull request #556: LUCENE-10330: Make the mmap directory tests fail by default, if unmapping does not work

dweiss commented on a change in pull request #556:
URL: https://github.com/apache/lucene/pull/556#discussion_r772625522



##########
File path: lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestModularLayer.java
##########
@@ -292,4 +293,17 @@ public void testAllOpenPackagesInSync() throws IOException {
           .collect(Collectors.toCollection(TreeSet::new));
     }
   }
+

Review comment:
       I think this should go into modular tests for lucene.core(.test) instead of the distribution tests - there it makes more sense and you don't have to load the module dynamically.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org