You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <ch...@yahoo-inc.com> on 2012/03/02 03:08:57 UTC
Re: Review Request: 3.1 Backport of OOZIE-691 - to fix testcases to be
compatible with Hadoop 0.23
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3944/
-----------------------------------------------------------
(Updated 2012-03-02 02:08:57.771071)
Review request for oozie.
Summary
-------
Backporting the changes to Oozie testcases (OOZIE-691) in branch 3.1 so they can be run against Hadoop 23
This addresses bugs OOZIE-714 and OOZIE-716.
https://issues.apache.org/jira/browse/OOZIE-714
https://issues.apache.org/jira/browse/OOZIE-716
Diffs (updated)
-----
branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/service/KerberosHadoopAccessorService.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1244331
Diff: https://reviews.apache.org/r/3944/diff
Testing
-------
yes
Thanks,
Mona
Re: Review Request: OOZIE-714,
716 and 3.1 Backport of OOZIE-691 - Fix testcases to be compatible with
Hadoop 0.23
Posted by Mohamed Battisha <mb...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3944/#review5641
-----------------------------------------------------------
Ship it!
+1 Looks good
- Mohamed
On 2012-03-02 19:11:19, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3944/
> -----------------------------------------------------------
>
> (Updated 2012-03-02 19:11:19)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Backporting the changes to Oozie testcases (OOZIE-691) in branch 3.1 so they can be run against Hadoop 23
>
>
> This addresses bugs OOZIE-714 and OOZIE-716.
> https://issues.apache.org/jira/browse/OOZIE-714
> https://issues.apache.org/jira/browse/OOZIE-716
>
>
> Diffs
> -----
>
> branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1244331
> branches/branch-3.1/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1244331
> branches/branch-3.1/core/src/main/java/org/apache/oozie/service/KerberosHadoopAccessorService.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1244331
>
> Diff: https://reviews.apache.org/r/3944/diff
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-714,
716 and 3.1 Backport of OOZIE-691 - Fix testcases to be compatible with
Hadoop 0.23
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3944/
-----------------------------------------------------------
(Updated 2012-03-07 01:31:28.703322)
Review request for oozie.
Changes
-------
Final patch after reviews and corrections. Breakdown of class changes for clarity. (total 20)
Backport of https://reviews.apache.org/r/2778/ "Make Oozie compile with Hadoop 0.23" [4]
-KerberosHadoopAccessorService
-HadoopAccessorService
-TestJavaActionExecutor
-TestDistCpActionExecutor
OOZIE-691 backport [7]
-JavaActionExecutor
-TestLauncher
-TestMapReduceActionError
-TestMapReduceActionExecutor
-TestMapReduceMain
-TestPipesMain
-TestStreamingMain
OOZIE-724 backport [1]
-TestClassUtils
OOZIE-729 backport [2]
-SubmitMRCommand
-SubmitMRXCommand
OOZIE-714 [2]
-TestPigMain
-TestPigActionExecutor
OOZIE-716 [4]
-TestActionStartXCommand
-TestActionCheckXCommand
-TestRecoveryService
-TestCoordELEvaluator
Only one testcase - TestWorkflowActionKillXCommand fails now (Oozie trunk too). Will file separate JIRA and patch for it.
Summary
-------
Backporting the changes to Oozie testcases (OOZIE-691) in branch 3.1 so they can be run against Hadoop 23
This addresses bugs OOZIE-714 and OOZIE-716.
https://issues.apache.org/jira/browse/OOZIE-714
https://issues.apache.org/jira/browse/OOZIE-716
Diffs (updated)
-----
branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/command/wf/SubmitMRCommand.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/command/wf/SubmitMRXCommand.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/service/KerberosHadoopAccessorService.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1244331
Diff: https://reviews.apache.org/r/3944/diff
Testing
-------
yes
Thanks,
Mona
Re: Review Request: OOZIE-714,
716 and 3.1 Backport of OOZIE-691 - Fix testcases to be compatible with
Hadoop 0.23
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3944/
-----------------------------------------------------------
(Updated 2012-03-02 19:11:19.638626)
Review request for oozie.
Changes
-------
incorporated review comments
Summary
-------
Backporting the changes to Oozie testcases (OOZIE-691) in branch 3.1 so they can be run against Hadoop 23
This addresses bugs OOZIE-714 and OOZIE-716.
https://issues.apache.org/jira/browse/OOZIE-714
https://issues.apache.org/jira/browse/OOZIE-716
Diffs (updated)
-----
branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/service/KerberosHadoopAccessorService.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1244331
Diff: https://reviews.apache.org/r/3944/diff
Testing
-------
yes
Thanks,
Mona
Re: Review Request: OOZIE-714,
716 and 3.1 Backport of OOZIE-691 - Fix testcases to be compatible with
Hadoop 0.23
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
> On 2012-03-02 05:24:24, Mohamed Battisha wrote:
> > branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, line 791
> > <https://reviews.apache.org/r/3944/diff/5/?file=87270#file87270line791>
> >
> > any reason for changing it from protected to public
was trying this while changing another testcase. Reverted it. Thanks for pointing out.
> On 2012-03-02 05:24:24, Mohamed Battisha wrote:
> > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java, line 216
> > <https://reviews.apache.org/r/3944/diff/5/?file=87277#file87277line216>
> >
> > in some files you setting the config before injecting the Kerberos Info. In others you are doing it after.
> >
> > I believe you should be consistent and set it before will be better
Okay. Taking consistency into account.
> On 2012-03-02 05:24:24, Mohamed Battisha wrote:
> > branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java, line 232
> > <https://reviews.apache.org/r/3944/diff/5/?file=87277#file87277line232>
> >
> > any reason for increasing the wait time. is the new changes will impact the wait time
Was checking before if increasing wait time allows for job status change expected. Changing it back after verifying not necessary
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3944/#review5541
-----------------------------------------------------------
On 2012-03-02 02:56:41, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3944/
> -----------------------------------------------------------
>
> (Updated 2012-03-02 02:56:41)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Backporting the changes to Oozie testcases (OOZIE-691) in branch 3.1 so they can be run against Hadoop 23
>
>
> This addresses bugs OOZIE-714 and OOZIE-716.
> https://issues.apache.org/jira/browse/OOZIE-714
> https://issues.apache.org/jira/browse/OOZIE-716
>
>
> Diffs
> -----
>
> branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1244331
> branches/branch-3.1/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1244331
> branches/branch-3.1/core/src/main/java/org/apache/oozie/service/KerberosHadoopAccessorService.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1244331
>
> Diff: https://reviews.apache.org/r/3944/diff
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-714,
716 and 3.1 Backport of OOZIE-691 - Fix testcases to be compatible with
Hadoop 0.23
Posted by Mohamed Battisha <mb...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3944/#review5541
-----------------------------------------------------------
sounds good, few comments/questions
branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/3944/#comment11967>
any reason for changing it from protected to public
branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/3944/#comment11968>
extra spaces
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
<https://reviews.apache.org/r/3944/#comment11970>
in some files you setting the config before injecting the Kerberos Info. In others you are doing it after.
I believe you should be consistent and set it before will be better
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
<https://reviews.apache.org/r/3944/#comment11969>
any reason for increasing the wait time. is the new changes will impact the wait time
- Mohamed
On 2012-03-02 02:56:41, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3944/
> -----------------------------------------------------------
>
> (Updated 2012-03-02 02:56:41)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Backporting the changes to Oozie testcases (OOZIE-691) in branch 3.1 so they can be run against Hadoop 23
>
>
> This addresses bugs OOZIE-714 and OOZIE-716.
> https://issues.apache.org/jira/browse/OOZIE-714
> https://issues.apache.org/jira/browse/OOZIE-716
>
>
> Diffs
> -----
>
> branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1244331
> branches/branch-3.1/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1244331
> branches/branch-3.1/core/src/main/java/org/apache/oozie/service/KerberosHadoopAccessorService.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1244331
> branches/branch-3.1/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1244331
>
> Diff: https://reviews.apache.org/r/3944/diff
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-714,
716 and 3.1 Backport of OOZIE-691 - Fix testcases to be compatible with
Hadoop 0.23
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3944/
-----------------------------------------------------------
(Updated 2012-03-02 02:56:41.279223)
Review request for oozie.
Changes
-------
removed whitespace
Summary
-------
Backporting the changes to Oozie testcases (OOZIE-691) in branch 3.1 so they can be run against Hadoop 23
This addresses bugs OOZIE-714 and OOZIE-716.
https://issues.apache.org/jira/browse/OOZIE-714
https://issues.apache.org/jira/browse/OOZIE-716
Diffs (updated)
-----
branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/service/KerberosHadoopAccessorService.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1244331
Diff: https://reviews.apache.org/r/3944/diff
Testing
-------
yes
Thanks,
Mona
Re: Review Request: OOZIE-714,
716 and 3.1 Backport of OOZIE-691 - Fix testcases to be compatible with
Hadoop 0.23
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3944/
-----------------------------------------------------------
(Updated 2012-03-02 02:55:02.464845)
Review request for oozie.
Changes
-------
debug statement removed
Summary (updated)
-------
Backporting the changes to Oozie testcases (OOZIE-691) in branch 3.1 so they can be run against Hadoop 23
This addresses bugs OOZIE-714 and OOZIE-716.
https://issues.apache.org/jira/browse/OOZIE-714
https://issues.apache.org/jira/browse/OOZIE-716
Diffs (updated)
-----
branches/branch-3.1/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1244331
branches/branch-3.1/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/service/KerberosHadoopAccessorService.java 1244331
branches/branch-3.1/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1244331
Diff: https://reviews.apache.org/r/3944/diff
Testing
-------
yes
Thanks,
Mona