[GitHub] [superset] geido edited a comment on pull request #17792: feat: color consistency

[GitBox <gi...@apache.org>]

geido edited a comment on pull request #17792:
URL: https://github.com/apache/superset/pull/17792#issuecomment-1018661327


   @stephenLYZ I also made a little bit of testing, below are some thoughts/findings:
   
   - When I remove the charts that share labels, I would expect that the `shared_label_colors` will get cleaned up from all of the labels that are not shared or that do not exist anymore in the context of the Dashboard. Imagine someone working on a large Dashboard and adding/removing charts multiple times, the `shared_label_colors` will eventually get very large with data that is not really needed.
   - When changing the color scheme from the Dashboard properties -> Color scheme, I saw that the `shared_label_colors` was wiped out and not re-generated, even though I have charts sharing labels. I was expecting that to be re-generated with the updated colors from the chosen scheme. It looks like this only happens when you remove or add a new chart in the Dashboard and then you change the color scheme. Watch the video below
   
   https://user-images.githubusercontent.com/60598000/150560405-1d169b24-686f-4204-831e-252f3b4dc42f.mp4
   
   - When you add charts to the Dashboard, it looks like the `shared_label_colors` is not updated. It only gets updated when you change the color scheme. Also, it appears that the previous labels that were there already got deleted while they shouldn't.
   
   https://user-images.githubusercontent.com/60598000/150562945-c3d0f2ab-6c48-41b5-a376-4f13dee72a9c.mp4
   
   - I deleted some charts from the Dashboard. Then I changed the color scheme. The `shared_label_colors`  is still getting the labels also of the charts that I deleted. I think it's not getting the most updated state of the Dashboard. It gets the correct state only when hard-refreshing the Dashboard page.
   
   I'll be back to testing once these things are tackled as I don't want to put too much on the plate right now. Let's jump on a call if anything isn't clear or if you need any help sorting these out!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org