You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Akshesh Doshi (Code Review)" <ge...@cloudera.org> on 2019/04/21 05:10:54 UTC
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Akshesh Doshi has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13070
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Make infra/python compatible with both Python 2 & 3
Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
---
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/find_py26.py
M infra/python/deps/pip_download.py
3 files changed, 18 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/13070/1
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 1
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4065/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 4
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 15:22:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13070/1/infra/python/deps/find_py26.py
File infra/python/deps/find_py26.py:
http://gerrit.cloudera.org:8080/#/c/13070/1/infra/python/deps/find_py26.py@45
PS1, Line 45: print(detect_python_cmd())
flake8: E305 expected 2 blank lines after class or function definition, found 1
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 1
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Apr 2019 05:11:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Make infra/python compatible with both Python 2 & 3
Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Reviewed-on: http://gerrit.cloudera.org:8080/13070
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Akshesh Doshi <ak...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/find_py26.py
M infra/python/deps/pip_download.py
3 files changed, 25 insertions(+), 15 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
Akshesh Doshi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 5
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 2:
(4 comments)
These changes seem fine, thanks for fixing. There's going to be the risk of regressions until we test this pre-commit, and I don't want to ask contributors to do extra work before we've automated it, but no harm in fixing them best-effort.
I think we could avoid print-related regressions with "from __future__ import print_function", so I suggested a few places to add that.
Once the few minor things I suggested are fixed, looks good to merge.
http://gerrit.cloudera.org:8080/#/c/13070/2/infra/python/bootstrap_virtualenv.py
File infra/python/bootstrap_virtualenv.py:
PS2:
Maybe add "from __future__ import print_function" to prevent this regressing in future: https://stackoverflow.com/questions/32032697/how-to-use-from-future-import-print-function
http://gerrit.cloudera.org:8080/#/c/13070/2/infra/python/deps/find_py26.py
File infra/python/deps/find_py26.py:
PS2:
Maybe add "from __future__ import print_function" to prevent this regressing in future: https://stackoverflow.com/questions/32032697/how-to-use-from-future-import-print-function
http://gerrit.cloudera.org:8080/#/c/13070/2/infra/python/deps/pip_download.py
File infra/python/deps/pip_download.py:
PS2:
Maybe add "from __future__ import print_function" to prevent this regressing in future: https://stackoverflow.com/questions/32032697/how-to-use-from-future-import-print-function
http://gerrit.cloudera.org:8080/#/c/13070/2/infra/python/deps/pip_download.py@32
PS2, Line 32: try:
Can you add a one line comment to explain this?
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 2
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Apr 2019 20:49:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Akshesh Doshi (Code Review)" <ge...@cloudera.org>.
Akshesh Doshi has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 2:
Tried pushing again with different network and checked the ssh keys set up on Gerrit, but no luck this time either.
If anyone wants to cherry-pick the commit, they can find it at https://github.com/akki/impala/pull/1/files
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 2
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 04:29:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Akshesh Doshi (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13070
to look at the new patch set (#2).
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Make infra/python compatible with both Python 2 & 3
Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
---
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/find_py26.py
M infra/python/deps/pip_download.py
3 files changed, 19 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/13070/2
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 2
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 4
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 20:43:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Akshesh Doshi (Code Review)" <ge...@cloudera.org>.
Akshesh Doshi has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 2:
Thanks for reviewing this Tim.
I agree with your comments and will incorporate them (probably till tomorrow).
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 2
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 04:23:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 5:
Thanks for the contribution Akshesh!
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 5
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 21:12:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Akshesh Doshi (Code Review)" <ge...@cloudera.org>.
Akshesh Doshi has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 1: Code-Review+1
.
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 1
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Apr 2019 05:13:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 3
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 15:22:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 4:
The job I started - https://jenkins.impala.io/job/gerrit-verify-dryrun/4065/ - will automatically merge it if/when the tests pass. It takes a few hours.
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 4
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 17:04:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Akshesh Doshi (Code Review)" <ge...@cloudera.org>.
Akshesh Doshi has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 4: Code-Review+1
Thank you so much Tim - appreciate your efforts.
What would now be the next step to merge this?
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 4
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 15:32:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Akshesh Doshi (Code Review)" <ge...@cloudera.org>.
Akshesh Doshi has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 2: Code-Review+1
> Patch Set 1:
>
> (1 comment)
Resolved
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 2
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Apr 2019 05:20:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2849/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 2
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Apr 2019 06:03:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2912/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 3
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 16:08:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 2:
I've been able to push to gerrit.cloudera.org this morning, so not sure what is wrong - maybe retry?
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 2
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 18:34:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 4
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 15:22:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Akshesh Doshi (Code Review)" <ge...@cloudera.org>.
Akshesh Doshi has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 2:
While trying to build Impala from [this guide](https://cwiki.apache.org/confluence/display/IMPALA/Building+Impala) I had to make the following changes to make the involved scripts Python3 compatible.
I am not sure if there is any other Python code in the project so I have kept this code compatible with both Python 2 & 3 (as I reckon that you only support Python 2 right now).
But this code can be merged as it will not break for any current Python 2 maintainers AND will also be helpful for developers like me who have shifted to Python3.
[Support for Python 2 is going to be dropped after 1st Jan 2020 according to current announcements.](https://pythonclock.org)
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 2
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Apr 2019 05:36:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Akshesh Doshi (Code Review)" <ge...@cloudera.org>.
Akshesh Doshi has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 5:
Yayy.. thanks Tim! :)
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 5
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Apr 2019 12:41:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 3:
That's weird. Anyway I was able to grab the patchset from your github account, so no worries.
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 3
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 15:22:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has uploaded a new patch set (#3) to the change originally created by Akshesh Doshi. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Make infra/python compatible with both Python 2 & 3
Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
---
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/find_py26.py
M infra/python/deps/pip_download.py
3 files changed, 25 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/13070/3
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 3
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Akshesh Doshi (Code Review)" <ge...@cloudera.org>.
Akshesh Doshi has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 2:
I am getting the following error when trying to push code
```bash
ssh: connect to host gerrit.cloudera.org port 29418: Operation timed out
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
```
The same command `git push -f asf-gerrit HEAD:refs/for/master` was working yesterday. Is the git remote server down?
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 2
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 15:40:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Make infra/python compatible with both Python 2 & 3
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13070 )
Change subject: Make infra/python compatible with both Python 2 & 3
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2848/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4285a021bb581f88425daa52ef8a3f844017d82
Gerrit-Change-Number: 13070
Gerrit-PatchSet: 1
Gerrit-Owner: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Akshesh Doshi <ak...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 Apr 2019 05:55:43 +0000
Gerrit-HasComments: No