You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Norman Maurer (JIRA)" <se...@james.apache.org> on 2010/12/15 21:08:01 UTC

[jira] Created: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Replace commons-logging with jcl-over-slf4j
-------------------------------------------

                 Key: JAMES-1149
                 URL: https://issues.apache.org/jira/browse/JAMES-1149
             Project: JAMES Server
          Issue Type: Task
    Affects Versions: 3.0-M2
            Reporter: Norman Maurer
            Assignee: Norman Maurer
             Fix For: 3.0-M3


During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Felix Knecht (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000169#comment-13000169 ] 

Felix Knecht commented on JAMES-1149:
-------------------------------------

Ok. So the logger shipped and used with James server will be log4j forever :-).

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000181#comment-13000181 ] 

Norman Maurer commented on JAMES-1149:
--------------------------------------

I think we should at least call the wrapped logger methods then

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch, slfj4-protocols.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Felix Knecht (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000151#comment-13000151 ] 

Felix Knecht commented on JAMES-1149:
-------------------------------------

Yes, when casting you can do. But using the facade means that your not sure if the underlaying logging framework used is Log4J - it could be also another (see http://slf4j.org/manual.html#binding). I'm not sure if we can figure out the logging framework using inspection to set the log level. 

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000230#comment-13000230 ] 

Norman Maurer commented on JAMES-1149:
--------------------------------------

oh dear... I need more coffee. You are right.. sorry for the noise

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch, slfj4-protocols.patch, slfj4-protocols_1.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Eric Charles (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972039#action_12972039 ] 

Eric Charles commented on JAMES-1149:
-------------------------------------

It would be nice to use the same logging libraries in james projects. Are there any plan to use/align jcl-over-slf4j in james/imap/mailbox/protocols/... or are there any particular reason against it?

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Felix Knecht (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000146#comment-13000146 ] 

Felix Knecht commented on JAMES-1149:
-------------------------------------

There exists several (but not many) places where the log level is tried to set, e.g. in org.apache.james.container.spring.provider.log.LogProviderImpl. This is not possible using slf4j, as this is only a facade. Setting the log level programmatically would mean to set it directly to the underlaying logging framework - which ever this may be.

What shall we do in these cases?
IIRC LogProviderImpl is the only class setting log level and not being a testcase.

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973035#action_12973035 ] 

Norman Maurer commented on JAMES-1149:
--------------------------------------

+1 using the same all over the place would make it easier..

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000147#comment-13000147 ] 

Norman Maurer commented on JAMES-1149:
--------------------------------------

You refer to this:


    /*
     * (non-Javadoc)
     * @see org.apache.james.container.spring.provider.log.LogProviderManagementMBean#setLogLevel(java.lang.String, java.lang.String)
     */
    public void setLogLevel(String component, String loglevel) {
        if (getSupportedLogLevels().contains(loglevel) == false) {
            throw new IllegalArgumentException("Not supported loglevel given");
        } else {
            ((Log4JLogger)logMap.get(component)).getLogger().setLevel(Level.toLevel(loglevel));
        }
    }
?

As you see it cast its logger to Log4JLogger todo this. So it should be possible with slf4j too (when cast the Logger to the Log4J implementation). Or I'm wrong ?


> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000193#comment-13000193 ] 

Norman Maurer commented on JAMES-1149:
--------------------------------------

hmm.. I don't get why you print the log to stdout .. Can you explain why you do so ? I think this makes not much sense.

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch, slfj4-protocols.patch, slfj4-protocols_1.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Felix Knecht (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000223#comment-13000223 ] 

Felix Knecht commented on JAMES-1149:
-------------------------------------

Your talking about org.apache.james.protocols.smtp.core.fastfail.MockLog ?
Because it's already done this way before:

package org.apache.james.protocols.smtp.core.fastfail;

import org.apache.commons.logging.Log;

public class MockLog implements Log{

    public void debug(Object arg0) {
        System.out.println(arg0);
    }

    public void debug(Object arg0, Throwable arg1) {
        System.out.println(arg0);
        arg1.printStackTrace();


    }

    public void error(Object arg0) {
        System.out.println(arg0);
        
    }
...

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch, slfj4-protocols.patch, slfj4-protocols_1.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13000165#comment-13000165 ] 

Norman Maurer commented on JAMES-1149:
--------------------------------------

Yeah sure.. but its a james server specific implementation which use log4j. So I think its ok to cast it. 

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Felix Knecht (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht updated JAMES-1149:
--------------------------------

    Attachment: removeStackTrace.patch

minor cleanup, don't print stacktrace when logging it

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: removeStackTrace.patch, slfj4-imap.patch, slfj4-mailbox.patch, slfj4-protocols.patch, slfj4-protocols_1.patch, slfj4-server.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Felix Knecht (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht updated JAMES-1149:
--------------------------------

    Attachment: slfj4-protocols.patch

In impl/src/main/java/org/apache/james/protocols/impl/SessionLog.java only the already existing methods are implemented, all others are auto generated stubs. Is this a problem?

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch, slfj4-protocols.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Felix Knecht (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht updated JAMES-1149:
--------------------------------

    Attachment: slfj4-mailbox.patch
                slfj4-imap.patch

Replaces commons-logging with slfj4-api also in the code.
For tests slf4j-simple is used as logging-framework.
There is no logging-framework added as dependency (except testing) - otherwise I made a mistake.

I'll start over with the server now (tomorrow), but it's quite a bit bigger I think.

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Felix Knecht (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht updated JAMES-1149:
--------------------------------

    Attachment: slfj4-protocols_1.patch

Replaces slfj4-protocols.patch

"I think we should at least call the wrapped logger methods then "

Thanks, could have thought of this myself ...

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch, slfj4-protocols.patch, slfj4-protocols_1.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Felix Knecht (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht updated JAMES-1149:
--------------------------------

    Attachment: slfj4-server.patch

- Server uses apache-mailet-2.4 which has deprecated methods in MailetContext. To not change to snapshot version I add a TODO where needed because of [1] and used the deprecated methods instead.
- Upgrade log4j version 1.2.14 -> 1.2.16
- Removed commons-logging dependency
- Add slf4j depndencies
- Use apache-protocols version 1.4-SNAPSHOT instead 1.3

In [2] the underlaying logging framework (log4j) is hardcoded used to set the log level. This may become a problem when changing the underlaying logging framework (OSGI?).

Having applied all the already contributed patches (not sure if all are really needed) I can build the project, testcases are passing.
I can start the built distribution until I get an exception [3] which is likely to be the result of using default configuration or not enough permission as normal unix user.

NOTE: This error [3] I could only see when starting the application not in daemon mode (wrapper.daemonize=FALSE, bin/james script) - I couldn't find any errors in the log files.

[1] https://issues.apache.org/jira/browse/MAILET-36
[2] org.apache.james.container.spring.provider.log.LogProviderImpl
[3] jvm 1    | INFO  16:49:23,047 | james.mailspooler | org.apache.james.mailetcontainer.lib.JamesMailSpooler thread shutdown completed.
jvm 1    | 
jvm 1    | WrapperSimpleApp: Encountered an error running main: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'smtpserver': Invocation of init method failed; nested exception is org.jboss.netty.channel.ChannelException: Failed to bind to: 0.0.0.0/0.0.0.0:25
jvm 1    | org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'smtpserver': Invocation of init method failed; nested exception is org.jboss.netty.channel.ChannelException: Failed to bind to: 0.0.0.0/0.0.0.0:25
jvm 1    |      at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessBeforeInitialization(InitDestroyAnnotationBeanPostProcessor.java:133)


> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch, slfj4-protocols.patch, slfj4-protocols_1.patch, slfj4-server.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Resolved: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/JAMES-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Norman Maurer resolved JAMES-1149.
----------------------------------

    Resolution: Fixed

Applied the patch.. Everything works as aspected here. Thanks again for all the hard work...

> Replace commons-logging with jcl-over-slf4j
> -------------------------------------------
>
>                 Key: JAMES-1149
>                 URL: https://issues.apache.org/jira/browse/JAMES-1149
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0-M2
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 3.0-M3
>
>         Attachments: slfj4-imap.patch, slfj4-mailbox.patch, slfj4-protocols.patch, slfj4-protocols_1.patch, slfj4-server.patch
>
>
> During my expirements with OSGI I noticed all the problems when using commons-logging which use some classloader magic. I thinkwe should use jcl-over-slf4j to replace it to simplify stuff in the future.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org