You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2011/12/04 20:52:07 UTC
Review Request: Metadata request may not return an array of gadget URLs when
there is an error it may just return an error code and message need to
account for that in EE code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3005/
-----------------------------------------------------------
Review request for shindig and Stanton Sievers.
Summary
-------
When preloading a gadget the response usually is an array of gadget URLs with data about the gadget. However sometimes the response may actually just be an error code and message. We need to account for that case in the handler in the EE code.
This addresses bug SHINDIG-1666.
https://issues.apache.org/jira/browse/SHINDIG-1666
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js 1210178
Diff: https://reviews.apache.org/r/3005/diff
Testing
-------
Ran unit tests and common container
Thanks,
Ryan
Re: Review Request: Metadata request may not return an array of gadget URLs
when there is an error it may just return an error code and message need to
account for that in EE code
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3005/#review3661
-----------------------------------------------------------
Ship it!
LGTM
- Dan
On 2011-12-06 14:20:46, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3005/
> -----------------------------------------------------------
>
> (Updated 2011-12-06 14:20:46)
>
>
> Review request for shindig and Stanton Sievers.
>
>
> Summary
> -------
>
> When preloading a gadget the response usually is an array of gadget URLs with data about the gadget. However sometimes the response may actually just be an error code and message. We need to account for that case in the handler in the EE code.
>
>
> This addresses bug SHINDIG-1666.
> https://issues.apache.org/jira/browse/SHINDIG-1666
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js 1207574
>
> Diff: https://reviews.apache.org/r/3005/diff
>
>
> Testing
> -------
>
> Ran unit tests and common container
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Metadata request may not return an array of gadget URLs
when there is an error it may just return an error code and message need to
account for that in EE code
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3005/#review3662
-----------------------------------------------------------
Committed revision 1210961.
- Ryan
On 2011-12-06 14:20:46, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3005/
> -----------------------------------------------------------
>
> (Updated 2011-12-06 14:20:46)
>
>
> Review request for shindig and Stanton Sievers.
>
>
> Summary
> -------
>
> When preloading a gadget the response usually is an array of gadget URLs with data about the gadget. However sometimes the response may actually just be an error code and message. We need to account for that case in the handler in the EE code.
>
>
> This addresses bug SHINDIG-1666.
> https://issues.apache.org/jira/browse/SHINDIG-1666
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js 1207574
>
> Diff: https://reviews.apache.org/r/3005/diff
>
>
> Testing
> -------
>
> Ran unit tests and common container
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Metadata request may not return an array of gadget URLs
when there is an error it may just return an error code and message need to
account for that in EE code
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3005/
-----------------------------------------------------------
(Updated 2011-12-06 14:20:46.695618)
Review request for shindig and Stanton Sievers.
Changes
-------
More cleanup of the code. Dan can you take one final look?
Summary
-------
When preloading a gadget the response usually is an array of gadget URLs with data about the gadget. However sometimes the response may actually just be an error code and message. We need to account for that case in the handler in the EE code.
This addresses bug SHINDIG-1666.
https://issues.apache.org/jira/browse/SHINDIG-1666
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js 1207574
Diff: https://reviews.apache.org/r/3005/diff
Testing
-------
Ran unit tests and common container
Thanks,
Ryan
Re: Review Request: Metadata request may not return an array of gadget URLs
when there is an error it may just return an error code and message need to
account for that in EE code
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3005/
-----------------------------------------------------------
(Updated 2011-12-05 22:45:37.184195)
Review request for shindig and Stanton Sievers.
Changes
-------
Changes based on Dan's suggestions
Summary
-------
When preloading a gadget the response usually is an array of gadget URLs with data about the gadget. However sometimes the response may actually just be an error code and message. We need to account for that case in the handler in the EE code.
This addresses bug SHINDIG-1666.
https://issues.apache.org/jira/browse/SHINDIG-1666
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js 1207574
Diff: https://reviews.apache.org/r/3005/diff
Testing
-------
Ran unit tests and common container
Thanks,
Ryan
Re: Review Request: Metadata request may not return an array of gadget URLs
when there is an error it may just return an error code and message need to
account for that in EE code
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3005/#review3616
-----------------------------------------------------------
Ship it!
LGTM
- Stanton
On 2011-12-04 19:53:37, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3005/
> -----------------------------------------------------------
>
> (Updated 2011-12-04 19:53:37)
>
>
> Review request for shindig and Stanton Sievers.
>
>
> Summary
> -------
>
> When preloading a gadget the response usually is an array of gadget URLs with data about the gadget. However sometimes the response may actually just be an error code and message. We need to account for that case in the handler in the EE code.
>
>
> This addresses bug SHINDIG-1666.
> https://issues.apache.org/jira/browse/SHINDIG-1666
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js 1210178
>
> Diff: https://reviews.apache.org/r/3005/diff
>
>
> Testing
> -------
>
> Ran unit tests and common container
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Metadata request may not return an array of gadget URLs
when there is an error it may just return an error code and message need to
account for that in EE code
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3005/#review3618
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
<https://reviews.apache.org/r/3005/#comment8078>
This looks a bit cluttered to me.
What about:
context.preloadGadget(gadgetUrl, function(result) {
if (!result[gadgetUrl] || result[gadgetUrl].error)) {
// There was an error preloading the gadget URL lets try and render the
// URL EE if there is one
if (dataModel.url != null) {
navigateUrl_(element, dataModel, renderParams, opt_callback);
}
else if (opt_callback != null) {
// Sometimes the metadata request will return an error code and message without
// specifying the gadgets the request is for, in this case format the object the
// way we would expect it
opt_callback(site, result[gadgetUrl] || {error: result});
}
}
else {
context.navigateGadget(site, gadgetUrl, viewParams, localRenderParams,
function(metadata) {
if (opt_callback != null) {
opt_callback(site, metadata);
}
});
}
});
- Dan
On 2011-12-04 19:53:37, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3005/
> -----------------------------------------------------------
>
> (Updated 2011-12-04 19:53:37)
>
>
> Review request for shindig and Stanton Sievers.
>
>
> Summary
> -------
>
> When preloading a gadget the response usually is an array of gadget URLs with data about the gadget. However sometimes the response may actually just be an error code and message. We need to account for that case in the handler in the EE code.
>
>
> This addresses bug SHINDIG-1666.
> https://issues.apache.org/jira/browse/SHINDIG-1666
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js 1210178
>
> Diff: https://reviews.apache.org/r/3005/diff
>
>
> Testing
> -------
>
> Ran unit tests and common container
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Metadata request may not return an array of gadget URLs
when there is an error it may just return an error code and message need to
account for that in EE code
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3005/
-----------------------------------------------------------
(Updated 2011-12-04 19:53:37.810171)
Review request for shindig and Stanton Sievers.
Changes
-------
Removed white spaces
Summary
-------
When preloading a gadget the response usually is an array of gadget URLs with data about the gadget. However sometimes the response may actually just be an error code and message. We need to account for that case in the handler in the EE code.
This addresses bug SHINDIG-1666.
https://issues.apache.org/jira/browse/SHINDIG-1666
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js 1210178
Diff: https://reviews.apache.org/r/3005/diff
Testing
-------
Ran unit tests and common container
Thanks,
Ryan