[GitHub] [flink] snuyanzin commented on pull request #22254: [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction

["snuyanzin (via GitHub)" <gi...@apache.org>]

snuyanzin commented on PR #22254:
URL: https://github.com/apache/flink/pull/22254#issuecomment-1482573035

   Shouldn't it be replaced with `createTemporarySystemFunction` as mentioned in javadoc?
   ```
        * @deprecated Use {@link #createTemporarySystemFunction(String, UserDefinedFunction)} instead.
        *     Please note that the new method also uses the new type system and reflective extraction
        *     logic. It might be necessary to update the function implementation as well. See the
        *     documentation of {@link ScalarFunction} for more information on the new function design.
   ```
   
   Also with new approaches to checks types for nullability. And there will be an issue with `org.apache.flink.table.planner.runtime.utils.JavaUserDefinedScalarFunctions.NonDeterministicUdf` since it has inputs as primitives in java (will be translated to `NOT NULL`) and used in scala tests for `util.addTableSource[(Int, Int, String)]("MyTable", 'a, 'b, 'c)` which are nullable. 
   I guess either test should be moved to java to test it with primitives or function definition should be changed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org