You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markap14 <gi...@git.apache.org> on 2017/11/22 14:56:37 UTC
[GitHub] nifi pull request #2288: NIFI-4632: Add the local hostname to the list of va...
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2288
NIFI-4632: Add the local hostname to the list of validated host headers
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4632
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2288
----
commit 80ff1fe73b983ea380790ef8ae55d4cb10f0702b
Author: Mark Payne <ma...@hotmail.com>
Date: 2017-11-22T14:56:09Z
NIFI-4632: Add the local hostname to the list of validated host headers
----
---
[GitHub] nifi issue #2288: NIFI-4632: Add the local hostname to the list of validated...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2288
Thanks Mark. I’ll take a look and hopefully merge this in tonight.
---
[GitHub] nifi issue #2288: NIFI-4632: Add the local hostname to the list of validated...
Posted by simnotes <gi...@git.apache.org>.
Github user simnotes commented on the issue:
https://github.com/apache/nifi/pull/2288
I ran into an issue with this change:
I built this into a pod on kubernetes and configured a load-balancer-service as a proxy in kubernetes. Got the error-message:
System Error
The request contained an invalid host header [<service-proxy-url>:8080] in the request [/nifi]. Check for request manipulation or third-party intercept.
---
[GitHub] nifi pull request #2288: NIFI-4632: Add the local hostname to the list of va...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2288
---
[GitHub] nifi issue #2288: NIFI-4632: Add the local hostname to the list of validated...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2288
I built this and set up a local instance doing S2S without having to populate the `nifi.web.http.host` value. I got a weird error message briefly but I had put the wrong remote port in to the RPG configuration. With the correct values, everything worked normally.
Error message for posterity/future recall:
`2017-11-27 19:01:38,897 ERROR [Site-to-Site Worker Thread-11] o.a.nifi.remote.SocketRemoteSiteListener Unable to communicate with remote instance null due to org.apache.nifi.remote.exception.HandshakeException: Handshake with nifi://localhost:56899 failed because the Magic Header was not present; closing connection`
Ran `contrib-check` and all tests pass. +1, merging.
---
[GitHub] nifi issue #2288: NIFI-4632: Add the local hostname to the list of validated...
Posted by elgalu <gi...@git.apache.org>.
Github user elgalu commented on the issue:
https://github.com/apache/nifi/pull/2288
@simnotes how are you deploying to K8s? did you use https://github.com/AlexsJones/kubernetes-nifi-cluster ?
---