You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/02/01 03:58:33 UTC
[GitHub] [druid] paul-rogers opened a new pull request #12219: Support extension server commands
paul-rogers opened a new pull request #12219:
URL: https://github.com/apache/druid/pull/12219
### Description
See [Support Services in Extensions](https://github.com/apache/druid/issues/12218). Adds the support for an extension service in the `Main` routine, and provides the `PrivateApi` annotation to mark extension service REST endpoints as private.
This PR allows launching an extension service as:
`<druid> server <extn>`
As it turns out, an extension service can be added more simply: just by introducing a new command. However the resulting command is:
`<druid> <extn>`
Which introduces an odd asymmetry between built-in and extension servers. The proposed solution allows extension services to work identically to built-in services.
<hr>
This PR has:
- [X] been self-reviewed.
- [X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [X] been tested in a test Druid cluster (as part of the extension in question: hard to test by itself).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers closed pull request #12219: Support extension server commands
Posted by GitBox <gi...@apache.org>.
paul-rogers closed pull request #12219:
URL: https://github.com/apache/druid/pull/12219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on pull request #12219: Support extension server commands
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on pull request #12219:
URL: https://github.com/apache/druid/pull/12219#issuecomment-1028470825
Turns out there is a better way to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on pull request #12219: Support extension server commands
Posted by GitBox <gi...@apache.org>.
paul-rogers commented on pull request #12219:
URL: https://github.com/apache/druid/pull/12219#issuecomment-1027348537
Build fails due to incomplete unit tests in `Main`. But, `Main` is basically untestable as written. Happy to rewrite that code to make it testable, but it makes the PR larger and more complex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org