You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/07 02:52:20 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4798:
Decouple Key from Record
codecov-io edited a comment on issue #4798: Decouple Key from Record
URL: https://github.com/apache/incubator-pinot/pull/4798#issuecomment-550597112
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4798?src=pr&el=h1) Report
> Merging [#4798](https://codecov.io/gh/apache/incubator-pinot/pull/4798?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/aba5482f87e96d41e0b0ee9e403ecdb4a7eeece6?src=pr&el=desc) will **increase** coverage by `7.75%`.
> The diff coverage is `97.6%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4798?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4798 +/- ##
============================================
+ Coverage 49.84% 57.59% +7.75%
Complexity 4 4
============================================
Files 1211 1212 +1
Lines 65572 65591 +19
Branches 9559 9555 -4
============================================
+ Hits 32684 37779 +5095
+ Misses 30314 24948 -5366
- Partials 2574 2864 +290
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4798?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../pinot/core/data/table/ConcurrentIndexedTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/4798/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0NvbmN1cnJlbnRJbmRleGVkVGFibGUuamF2YQ==) | `89.55% <100%> (+0.15%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/core/data/table/SimpleIndexedTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/4798/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1NpbXBsZUluZGV4ZWRUYWJsZS5qYXZh) | `94.82% <100%> (+0.09%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/pinot/core/query/reduce/BrokerReduceService.java](https://codecov.io/gh/apache/incubator-pinot/pull/4798/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQnJva2VyUmVkdWNlU2VydmljZS5qYXZh) | `83.53% <100%> (+13.77%)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/pinot/core/data/table/IndexedTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/4798/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0luZGV4ZWRUYWJsZS5qYXZh) | `100% <100%> (+9.52%)` | `0 <0> (ø)` | :arrow_down: |
| [...core/operator/blocks/IntermediateResultsBlock.java](https://codecov.io/gh/apache/incubator-pinot/pull/4798/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvSW50ZXJtZWRpYXRlUmVzdWx0c0Jsb2NrLmphdmE=) | `85% <100%> (+8.17%)` | `0 <0> (ø)` | :arrow_down: |
| [...t/core/operator/CombineGroupByOrderByOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4798/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lR3JvdXBCeU9yZGVyQnlPcGVyYXRvci5qYXZh) | `81.08% <100%> (+1.27%)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/pinot/core/data/table/TableResizer.java](https://codecov.io/gh/apache/incubator-pinot/pull/4798/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1RhYmxlUmVzaXplci5qYXZh) | `98.41% <100%> (ø)` | `0 <0> (?)` | |
| [.../java/org/apache/pinot/core/data/table/Record.java](https://codecov.io/gh/apache/incubator-pinot/pull/4798/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1JlY29yZC5qYXZh) | `80% <50%> (-5.72%)` | `0 <0> (ø)` | |
| [...va/org/apache/pinot/core/data/table/BaseTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/4798/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0Jhc2VUYWJsZS5qYXZh) | `91.3% <91.3%> (ø)` | `0 <0> (?)` | |
| [...ore/query/scheduler/resources/ResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4798/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zY2hlZHVsZXIvcmVzb3VyY2VzL1Jlc291cmNlTWFuYWdlci5qYXZh) | `85.71% <0%> (-10.72%)` | `0% <0%> (ø)` | |
| ... and [295 more](https://codecov.io/gh/apache/incubator-pinot/pull/4798/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4798?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4798?src=pr&el=footer). Last update [aba5482...0582f65](https://codecov.io/gh/apache/incubator-pinot/pull/4798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org