[jira] Commented: (HARMONY-5517) [classlib][archive] simplifying archive code by fixing manifest encoding to UTF-8

["Alexei Fedotov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578286#action_12578286 ] 

Alexei Fedotov commented on HARMONY-5517:
-----------------------------------------

Tim, thank you for committing the patch.

I have noticed that you added throw new IOException(e.getLocalizedMessage()) for unrecognized UTF characters. Personally I want all errors to be reported. From the other side a former code tried to to its best to recognize the code and my understanding of the specification suggested ignoring non-recognizable attributes.

Please check http://java.sun.com/j2se/1.5.0/docs/guide/jar/jar.html, Notes on Manifest and Signature Files, Attributes. Probably they just meant  attribute names here, not a corrupted UTF -8 characters.


> [classlib][archive] simplifying archive code by fixing manifest encoding to UTF-8
> ---------------------------------------------------------------------------------
>
>                 Key: HARMONY-5517
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5517
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Tim Ellison
>             Fix For: 5.0M6
>
>         Attachments: remove_manifest_encoding.patch, remove_manifest_encoding_2.patch, remove_manifest_encoding_3.patch
>
>
> By specification [1] manifests are encoded in UTF-8. There is no need to make code more complex than that, so legacy of HARMONY-14 may be removed. Testing the patch.
> [1] http://java.sun.com/javase/6/docs/technotes/guides/jar/jar.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.