You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/06 10:04:02 UTC
[GitHub] [pulsar] Huanli-Meng opened a new pull request #8463: [Doc]--remove pulsarctl from pulsar docs
Huanli-Meng opened a new pull request #8463:
URL: https://github.com/apache/pulsar/pull/8463
Fixes #8400
### Motivation
pulsarctl is not supported for pulsar docs. Therefore, remove pulsarctl commands and code examples
### Modifications
use pulsar-admin commands and code examples to replace pulsarctl commands and code examples.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #8463: [Doc]--remove pulsarctl from pulsar docs
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #8463:
URL: https://github.com/apache/pulsar/pull/8463#discussion_r519374676
##########
File path: site2/docs/tiered-storage-filesystem.md
##########
@@ -218,12 +218,12 @@ To trigger via CLI tools, you need to specify the maximum amount of data (thresh
> #### Tip
>
- > For more information about the `pulsarctl topic offload options` command, including flags, descriptions, default values, and shorthands, see [here](https://streamnative.io/docs/pulsarctl/v0.4.0/#-em-offload-em-).
+ > For more information about the `pulsar-admin topics offload options` command, including flags, descriptions, default values, and shorthands, see [here](https://pulsar.apache.org/docs/en/next/pulsar-admin/#offload).
Review comment:
use relative path
use "(reference-pulsar-admin.md#offload)" in the link
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #8463: [Doc]--remove pulsarctl from pulsar docs
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #8463:
URL: https://github.com/apache/pulsar/pull/8463#discussion_r519375056
##########
File path: site2/docs/tiered-storage-filesystem.md
##########
@@ -261,7 +261,7 @@ To trigger via CLI tools, you need to specify the maximum amount of data (thresh
> #### Tip
>
- > For more information about the `pulsarctl topic offload-status options` command, including flags, descriptions, default values, and shorthands, see [here](https://streamnative.io/docs/pulsarctl/v0.4.0/#-em-offload-status-em-).
+ > For more information about the `pulsar-admin topics offload-status options` command, including flags, descriptions, default values, and shorthands, see [here](https://pulsar.apache.org/docs/en/next/pulsar-admin/#offload-status).
Review comment:
use relative path and check all similar cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng merged pull request #8463: [Doc]--remove pulsarctl from pulsar docs
Posted by GitBox <gi...@apache.org>.
Huanli-Meng merged pull request #8463:
URL: https://github.com/apache/pulsar/pull/8463
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #8463: [Doc]--remove pulsarctl from pulsar docs
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #8463:
URL: https://github.com/apache/pulsar/pull/8463#discussion_r519374676
##########
File path: site2/docs/tiered-storage-filesystem.md
##########
@@ -218,12 +218,12 @@ To trigger via CLI tools, you need to specify the maximum amount of data (thresh
> #### Tip
>
- > For more information about the `pulsarctl topic offload options` command, including flags, descriptions, default values, and shorthands, see [here](https://streamnative.io/docs/pulsarctl/v0.4.0/#-em-offload-em-).
+ > For more information about the `pulsar-admin topics offload options` command, including flags, descriptions, default values, and shorthands, see [here](https://pulsar.apache.org/docs/en/next/pulsar-admin/#offload).
Review comment:
use relative path
use "(reference-pulsar-admin.md)" in the link
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #8463: [Doc]--remove pulsarctl from pulsar docs
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #8463:
URL: https://github.com/apache/pulsar/pull/8463#discussion_r519375056
##########
File path: site2/docs/tiered-storage-filesystem.md
##########
@@ -261,7 +261,7 @@ To trigger via CLI tools, you need to specify the maximum amount of data (thresh
> #### Tip
>
- > For more information about the `pulsarctl topic offload-status options` command, including flags, descriptions, default values, and shorthands, see [here](https://streamnative.io/docs/pulsarctl/v0.4.0/#-em-offload-status-em-).
+ > For more information about the `pulsar-admin topics offload-status options` command, including flags, descriptions, default values, and shorthands, see [here](https://pulsar.apache.org/docs/en/next/pulsar-admin/#offload-status).
Review comment:
use relative path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on pull request #8463: [Doc]--remove pulsarctl from pulsar docs
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on pull request #8463:
URL: https://github.com/apache/pulsar/pull/8463#issuecomment-724035397
@Jennifer88huang , Thanks a lot for your comments. Docs have been updated based on your comments. Please help double check them. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org