You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/12 02:30:34 UTC
[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #491: fix: remove the no use maxItemNum in dashboard
Fine0830 opened a new pull request #491:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/491
Remove the no use maxItemNum.
After fixing
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #491: fix: remove the no use maxItemNum in dashboard
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #491:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/491#issuecomment-839399683
Yep, it's better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wankai123 commented on pull request #491: fix: remove the no use maxItemNum for labeled-value metric, etc
Posted by GitBox <gi...@apache.org>.
wankai123 commented on pull request #491:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/491#issuecomment-839407900
I have updated UI & clean the cache, now it doesn't show on the panel, but still in the download template @Fine0830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #491: fix: remove the no use maxItemNum for labeled-value metric, etc
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #491:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/491#issuecomment-839422691
I haven't reproduced it by using Incognito Mode.
`{"name":"Global","children":[{"width":3,"title":"Services Load","height":"300","entityType":"Service","independentSelector":false,"metricType":"REGULAR_VALUE","metricName":"service_cpm","queryMetricType":"sortMetrics","chartType":"ChartSlow","parentService":false,"unit":"CPM - calls per minute","maxItemNum":10},{"width":3,"title":"Slow Services","height":"300","entityType":"Service","independentSelector":false,"metricType":"REGULAR_VALUE","metricName":"service_resp_time","queryMetricType":"sortMetrics","chartType":"ChartSlow","parentService":false,"unit":"ms","maxItemNum":10},{"width":3,"title":"Un-Health Services (Apdex)","height":"300","entityType":"Service","independentSelector":false,"metricType":"REGULAR_VALUE","metricName":"service_apdex","queryMetricType":"sortMetrics","chartType":"ChartSlow","parentService":false,"aggregation":"/","aggregationNum":"10000","sortOrder":"ASC","maxItemNum":10},{"width":3,"title":"Slow Endpoints","height":"300","entityType":"Endpoint","indepen
dentSelector":false,"metricType":"REGULAR_VALUE","metricName":"endpoint_avg","queryMetricType":"sortMetrics","chartType":"ChartSlow","parentService":false,"unit":"ms","maxItemNum":10},{"width":"6","title":"Global Response Latency","height":"280","entityType":"All","independentSelector":false,"metricType":"LABELED_VALUE","metricName":"all_percentile","queryMetricType":"readLabeledMetricsValues","chartType":"ChartLine","metricLabels":"P50, P75, P90, P95, P99","labelsIndex":"0, 1, 2, 3, 4","unit":"percentile in ms"},{"width":"6","title":"Global Heatmap","height":"280","entityType":"All","independentSelector":false,"metricType":"HEATMAP","unit":"ms","queryMetricType":"readHeatMap","chartType":"ChartHeatmap","metricName":"all_heatmap"},{"width":3,"title":"Title","height":350,"entityType":"Service","independentSelector":false,"metricType":"REGULAR_VALUE","metricName":"service_resp_time","queryMetricType":"readMetricsValues","chartType":"ChartLine"}]}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #491: fix: remove the no use maxItemNum in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #491:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/491#issuecomment-839395003
What do you remove exactly? I am confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #491: fix: remove the no use maxItemNum in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #491:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/491#issuecomment-839398449
> `maxItemNum` only works topN, `maxItemNum` value is the `N`. #481
Yes, this is the thing I can't confirm, and also want to make PR's title clear.
`fix: remove the no use maxItemNum for labeled-value metric`, is this better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 edited a comment on pull request #491: fix: remove the no use maxItemNum for labeled-value metric, etc
Posted by GitBox <gi...@apache.org>.
Fine0830 edited a comment on pull request #491:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/491#issuecomment-839422691
I haven't reproduced it by using Incognito Mode on my side.
`{"name":"Global","children":[{"width":3,"title":"Services Load","height":"300","entityType":"Service","independentSelector":false,"metricType":"REGULAR_VALUE","metricName":"service_cpm","queryMetricType":"sortMetrics","chartType":"ChartSlow","parentService":false,"unit":"CPM - calls per minute","maxItemNum":10},{"width":3,"title":"Slow Services","height":"300","entityType":"Service","independentSelector":false,"metricType":"REGULAR_VALUE","metricName":"service_resp_time","queryMetricType":"sortMetrics","chartType":"ChartSlow","parentService":false,"unit":"ms","maxItemNum":10},{"width":3,"title":"Un-Health Services (Apdex)","height":"300","entityType":"Service","independentSelector":false,"metricType":"REGULAR_VALUE","metricName":"service_apdex","queryMetricType":"sortMetrics","chartType":"ChartSlow","parentService":false,"aggregation":"/","aggregationNum":"10000","sortOrder":"ASC","maxItemNum":10},{"width":3,"title":"Slow Endpoints","height":"300","entityType":"Endpoint","indepen
dentSelector":false,"metricType":"REGULAR_VALUE","metricName":"endpoint_avg","queryMetricType":"sortMetrics","chartType":"ChartSlow","parentService":false,"unit":"ms","maxItemNum":10},{"width":"6","title":"Global Response Latency","height":"280","entityType":"All","independentSelector":false,"metricType":"LABELED_VALUE","metricName":"all_percentile","queryMetricType":"readLabeledMetricsValues","chartType":"ChartLine","metricLabels":"P50, P75, P90, P95, P99","labelsIndex":"0, 1, 2, 3, 4","unit":"percentile in ms"},{"width":"6","title":"Global Heatmap","height":"280","entityType":"All","independentSelector":false,"metricType":"HEATMAP","unit":"ms","queryMetricType":"readHeatMap","chartType":"ChartHeatmap","metricName":"all_heatmap"},{"width":3,"title":"Title","height":350,"entityType":"Service","independentSelector":false,"metricType":"REGULAR_VALUE","metricName":"service_resp_time","queryMetricType":"readMetricsValues","chartType":"ChartLine"}]}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng merged pull request #491: fix: remove the no use maxItemNum for labeled-value metric, etc
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #491:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #491: fix: remove the no use maxItemNum in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #491:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/491#issuecomment-839395251
How many labels visualized for a labeled-value metric?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #491: fix: remove the no use maxItemNum in dashboard
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #491:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/491#issuecomment-839397815
`maxItemNum` only works topN, `maxItemNum` value is the `N`. https://github.com/apache/skywalking-rocketbot-ui/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org