You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Ilan Kirsh (JIRA)" <ji...@apache.org> on 2006/08/09 10:19:13 UTC
[jira] Created: (JDO-404) GetFetchPlan - Is it really forbidden to
load extra fields?
GetFetchPlan - Is it really forbidden to load extra fields?
-----------------------------------------------------------
Key: JDO-404
URL: http://issues.apache.org/jira/browse/JDO-404
Project: JDO
Issue Type: Bug
Components: tck20
Affects Versions: JDO 2 final
Reporter: Ilan Kirsh
The tests in org.apache.jdo.tck.query.api.GetFetchPlan validate using jdoPostLoad that some fields are not loaded in the query results. This doesn't make sense for implementations in which avoiding loading value fields doesn't give any performance benefit, and I think that it is also against the spec (page 127):
"When an instance is loaded using getObjectById , a Query is executed, or an Extent is iterated, the implementation may choose to use the active fetch groups to prefetch data." - may choose and not must...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (JDO-404) GetFetchPlan - Is it really forbidden to
load extra fields?
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-404?page=all ]
Craig Russell reassigned JDO-404:
---------------------------------
Assignee: Michael Bouschen (was: Craig Russell)
> GetFetchPlan - Is it really forbidden to load extra fields?
> -----------------------------------------------------------
>
> Key: JDO-404
> URL: http://issues.apache.org/jira/browse/JDO-404
> Project: JDO
> Issue Type: Bug
> Components: tck20
> Affects Versions: JDO 2 final
> Reporter: Ilan Kirsh
> Assigned To: Michael Bouschen
> Fix For: JDO 2 maintenance release 1, JDO 2.0 TCK challenge fixes
>
>
> The tests in org.apache.jdo.tck.query.api.GetFetchPlan validate using jdoPostLoad that some fields are not loaded in the query results. This doesn't make sense for implementations in which avoiding loading value fields doesn't give any performance benefit, and I think that it is also against the spec (page 127):
> "When an instance is loaded using getObjectById , a Query is executed, or an Extent is iterated, the implementation may choose to use the active fetch groups to prefetch data." - may choose and not must...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (JDO-404) GetFetchPlan - Is it really forbidden to
load extra fields?
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-404?page=all ]
Michael Bouschen resolved JDO-404.
----------------------------------
Resolution: Fixed
Checked in the patch (see revision 453265).
> GetFetchPlan - Is it really forbidden to load extra fields?
> -----------------------------------------------------------
>
> Key: JDO-404
> URL: http://issues.apache.org/jira/browse/JDO-404
> Project: JDO
> Issue Type: Bug
> Components: tck20
> Affects Versions: JDO 2 final
> Reporter: Ilan Kirsh
> Assigned To: Michael Bouschen
> Fix For: JDO 2 maintenance release 1, JDO 2.0 TCK challenge fixes
>
> Attachments: JDO-404.patch
>
>
> The tests in org.apache.jdo.tck.query.api.GetFetchPlan validate using jdoPostLoad that some fields are not loaded in the query results. This doesn't make sense for implementations in which avoiding loading value fields doesn't give any performance benefit, and I think that it is also against the spec (page 127):
> "When an instance is loaded using getObjectById , a Query is executed, or an Extent is iterated, the implementation may choose to use the active fetch groups to prefetch data." - may choose and not must...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JDO-404) GetFetchPlan - Is it really forbidden to
load extra fields?
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-404?page=all ]
Craig Russell updated JDO-404:
------------------------------
Fix Version/s: JDO 2 maintenance release 1
> GetFetchPlan - Is it really forbidden to load extra fields?
> -----------------------------------------------------------
>
> Key: JDO-404
> URL: http://issues.apache.org/jira/browse/JDO-404
> Project: JDO
> Issue Type: Bug
> Components: tck20
> Affects Versions: JDO 2 final
> Reporter: Ilan Kirsh
> Fix For: JDO 2 maintenance release 1
>
>
> The tests in org.apache.jdo.tck.query.api.GetFetchPlan validate using jdoPostLoad that some fields are not loaded in the query results. This doesn't make sense for implementations in which avoiding loading value fields doesn't give any performance benefit, and I think that it is also against the spec (page 127):
> "When an instance is loaded using getObjectById , a Query is executed, or an Extent is iterated, the implementation may choose to use the active fetch groups to prefetch data." - may choose and not must...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JDO-404) GetFetchPlan - Is it really forbidden to
load extra fields?
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-404?page=all ]
Craig Russell updated JDO-404:
------------------------------
Fix Version/s: JDO 2.0 TCK challenge fixes
> GetFetchPlan - Is it really forbidden to load extra fields?
> -----------------------------------------------------------
>
> Key: JDO-404
> URL: http://issues.apache.org/jira/browse/JDO-404
> Project: JDO
> Issue Type: Bug
> Components: tck20
> Affects Versions: JDO 2 final
> Reporter: Ilan Kirsh
> Assigned To: Michael Bouschen
> Fix For: JDO 2 maintenance release 1, JDO 2.0 TCK challenge fixes
>
>
> The tests in org.apache.jdo.tck.query.api.GetFetchPlan validate using jdoPostLoad that some fields are not loaded in the query results. This doesn't make sense for implementations in which avoiding loading value fields doesn't give any performance benefit, and I think that it is also against the spec (page 127):
> "When an instance is loaded using getObjectById , a Query is executed, or an Extent is iterated, the implementation may choose to use the active fetch groups to prefetch data." - may choose and not must...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JDO-404) GetFetchPlan - Is it really forbidden
to load extra fields?
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-404?page=comments#action_12440000 ]
Craig Russell commented on JDO-404:
-----------------------------------
The patch looks good.
> GetFetchPlan - Is it really forbidden to load extra fields?
> -----------------------------------------------------------
>
> Key: JDO-404
> URL: http://issues.apache.org/jira/browse/JDO-404
> Project: JDO
> Issue Type: Bug
> Components: tck20
> Affects Versions: JDO 2 final
> Reporter: Ilan Kirsh
> Assigned To: Michael Bouschen
> Fix For: JDO 2 maintenance release 1, JDO 2.0 TCK challenge fixes
>
> Attachments: JDO-404.patch
>
>
> The tests in org.apache.jdo.tck.query.api.GetFetchPlan validate using jdoPostLoad that some fields are not loaded in the query results. This doesn't make sense for implementations in which avoiding loading value fields doesn't give any performance benefit, and I think that it is also against the spec (page 127):
> "When an instance is loaded using getObjectById , a Query is executed, or an Extent is iterated, the implementation may choose to use the active fetch groups to prefetch data." - may choose and not must...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JDO-404) GetFetchPlan - Is it really forbidden
to load extra fields?
Posted by "Ilan Kirsh (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-404?page=comments#action_12439986 ]
Ilan Kirsh commented on JDO-404:
--------------------------------
The patch seems to do the trick. Thanks.
> GetFetchPlan - Is it really forbidden to load extra fields?
> -----------------------------------------------------------
>
> Key: JDO-404
> URL: http://issues.apache.org/jira/browse/JDO-404
> Project: JDO
> Issue Type: Bug
> Components: tck20
> Affects Versions: JDO 2 final
> Reporter: Ilan Kirsh
> Assigned To: Michael Bouschen
> Fix For: JDO 2 maintenance release 1, JDO 2.0 TCK challenge fixes
>
> Attachments: JDO-404.patch
>
>
> The tests in org.apache.jdo.tck.query.api.GetFetchPlan validate using jdoPostLoad that some fields are not loaded in the query results. This doesn't make sense for implementations in which avoiding loading value fields doesn't give any performance benefit, and I think that it is also against the spec (page 127):
> "When an instance is loaded using getObjectById , a Query is executed, or an Extent is iterated, the implementation may choose to use the active fetch groups to prefetch data." - may choose and not must...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (JDO-404) GetFetchPlan - Is it really forbidden to
load extra fields?
Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-404?page=all ]
Craig Russell reassigned JDO-404:
---------------------------------
Assignee: Craig Russell
> GetFetchPlan - Is it really forbidden to load extra fields?
> -----------------------------------------------------------
>
> Key: JDO-404
> URL: http://issues.apache.org/jira/browse/JDO-404
> Project: JDO
> Issue Type: Bug
> Components: tck20
> Affects Versions: JDO 2 final
> Reporter: Ilan Kirsh
> Assigned To: Craig Russell
> Fix For: JDO 2 maintenance release 1
>
>
> The tests in org.apache.jdo.tck.query.api.GetFetchPlan validate using jdoPostLoad that some fields are not loaded in the query results. This doesn't make sense for implementations in which avoiding loading value fields doesn't give any performance benefit, and I think that it is also against the spec (page 127):
> "When an instance is loaded using getObjectById , a Query is executed, or an Extent is iterated, the implementation may choose to use the active fetch groups to prefetch data." - may choose and not must...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JDO-404) GetFetchPlan - Is it really forbidden to
load extra fields?
Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JDO-404?page=all ]
Michael Bouschen updated JDO-404:
---------------------------------
Attachment: JDO-404.patch
I agree. Since the implementation may choose to use the active fetch groups to prefetch data, the test cannot test this behaviour.
The attached patch for review removes the code from the test class that checks whether fields are loaded because a ceratin fetch group is active. The test still checks whether multiple calls of getFetchPlan return the identical instacne and whether addGroup/removeGroup modify the current fetch plan.
> GetFetchPlan - Is it really forbidden to load extra fields?
> -----------------------------------------------------------
>
> Key: JDO-404
> URL: http://issues.apache.org/jira/browse/JDO-404
> Project: JDO
> Issue Type: Bug
> Components: tck20
> Affects Versions: JDO 2 final
> Reporter: Ilan Kirsh
> Assigned To: Michael Bouschen
> Fix For: JDO 2 maintenance release 1, JDO 2.0 TCK challenge fixes
>
> Attachments: JDO-404.patch
>
>
> The tests in org.apache.jdo.tck.query.api.GetFetchPlan validate using jdoPostLoad that some fields are not loaded in the query results. This doesn't make sense for implementations in which avoiding loading value fields doesn't give any performance benefit, and I think that it is also against the spec (page 127):
> "When an instance is loaded using getObjectById , a Query is executed, or an Extent is iterated, the implementation may choose to use the active fetch groups to prefetch data." - may choose and not must...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira