You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/16 17:08:44 UTC

[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #3186: ARTEMIS-2109: fix ErrorProne for JDK8, move to profile

gemmellr commented on a change in pull request #3186:
URL: https://github.com/apache/activemq-artemis/pull/3186#discussion_r441009693



##########
File path: .travis.yml
##########
@@ -24,7 +24,7 @@ before_install:
 # By setting anything to org.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED we are disabling libaio loading on the testsuite
 script: 
 - set -e
-- mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Pfast-tests -Pextra-tests -Ptests-CI -B install -q
+- mvn -Dorg.apache.activemq.artemis.core.io.aio.AIOSequentialFileFactory.DISABLED=AnythingNotNull -Djdk8-errorprone -Pfast-tests -Pextra-tests -Ptests-CI -B install -q

Review comment:
       No, as that would enable the JDK8 arguments on 11+ and break them. The profile can be activated explicitly with -P or by JDK8+property. Using the property as here stops it from actually adding the JDK-8 specific bits on JDK11+ when run there (since the job script is shared across all 3) which would break.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org