You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/16 06:39:35 UTC

[GitHub] [incubator-superset] john-bodley commented on pull request #10061: fix: caching on viz with relative time ranges and time compare

john-bodley commented on pull request #10061:
URL: https://github.com/apache/incubator-superset/pull/10061#issuecomment-644563794


   @villebro we probably should double check the logic, i.e., it's clear they get the values of `from_dttm` and `to_dttm` at some stage, however it's not initially apparent these are the same from/to per https://github.com/apache/incubator-superset/blob/a3393c1bc424502caa62c7267bd616800c897685/superset/connectors/sqla/models.py#L731.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org