[GitHub] jordanly opened a new issue #31: Possible NullPointerException in InstanceActionHandler

[GitBox <gi...@apache.org>]

jordanly opened a new issue #31: Possible NullPointerException in InstanceActionHandler
URL: https://github.com/apache/aurora/issues/31
 
 
   After introducing the 'slaAware' field in [this commit](https://github.com/apache/aurora/commit/4e28e73bb83b75f1369a705d15c96e40fb7098e1), there has been a possible NullPointerException in [this line](https://github.com/apache/aurora/blob/master/src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java#L210). This happens when an update only kills instances. There is no `desiredState`, so `getDesiredState().getTask()` will try to act on a null object. Other places in the code guard against this case by checking `isSetDesiredState()` before retrieval.
   
   We should properly handle nulls in this case, and add generic end to end tests for only adding instances and only removing instances with updates.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services