You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:13:40 UTC

[GitHub] [incubator-tvm] masahi opened a new pull request #6828: [CI] Torch 1.7 update to mainline

masahi opened a new pull request #6828:
URL: https://github.com/apache/incubator-tvm/pull/6828


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen merged pull request #6828: [CI] Torch 1.7 update to mainline

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6828:
URL: https://github.com/apache/incubator-tvm/pull/6828


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] jcf94 commented on pull request #6828: [CI] Torch 1.7 update to mainline

Posted by GitBox <gi...@apache.org>.
jcf94 commented on pull request #6828:
URL: https://github.com/apache/incubator-tvm/pull/6828#issuecomment-720875473






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] masahi commented on a change in pull request #6828: [CI] Torch 1.7 update to mainline

Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #6828:
URL: https://github.com/apache/incubator-tvm/pull/6828#discussion_r516526502



##########
File path: tutorials/frontend/deploy_object_detection_pytorch.py
##########
@@ -27,16 +27,16 @@
 
 .. code-block:: bash
 
-    pip install torch==1.4.0
-    pip install torchvision==0.5.0
+    pip install torch==1.7.0
+    pip install torchvision==0.8.1
 
 or please refer to official site
 https://pytorch.org/get-started/locally/
 
 PyTorch versions should be backwards compatible but should be used
 with the proper TorchVision version.
 
-Currently, TVM supports PyTorch 1.4 and 1.3. Other versions may
+Currently, TVM supports PyTorch 1.7 and 1.4. Other versions may

Review comment:
       it's a good point, my reasoning is that since we've been testing with v1.4, and this upgrade doesn't break it (pytorch frontend tests pass on both 1.4 and 1.7), I think we can claim we still support 1.4.

##########
File path: tests/python/unittest/test_auto_scheduler_layout_rewrite.py
##########
@@ -166,5 +166,6 @@ def test_correctness_layout_rewrite_insert_transform_stage():
 
 if __name__ == "__main__":
     test_apply_steps_with_layout_rewrite()
-    test_correctness_layout_rewrite_rewrite_for_preTransformed()
-    test_correctness_layout_rewrite_insert_transform_stage()
+    # Disable for now due to being flaky on i386
+    # test_correctness_layout_rewrite_rewrite_for_preTransformed()
+    # test_correctness_layout_rewrite_insert_transform_stage()

Review comment:
       It's only a temporary measure, i386 tests should be fixed soon.

##########
File path: tests/python/unittest/test_auto_scheduler_layout_rewrite.py
##########
@@ -166,5 +166,6 @@ def test_correctness_layout_rewrite_insert_transform_stage():
 
 if __name__ == "__main__":
     test_apply_steps_with_layout_rewrite()
-    test_correctness_layout_rewrite_rewrite_for_preTransformed()
-    test_correctness_layout_rewrite_insert_transform_stage()
+    # Disable for now due to being flaky on i386
+    # test_correctness_layout_rewrite_rewrite_for_preTransformed()
+    # test_correctness_layout_rewrite_insert_transform_stage()

Review comment:
       It's only a temporary measure, i386 tests should be fixed soon. So I think this is ok for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] leandron commented on a change in pull request #6828: [CI] Torch 1.7 update to mainline

Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #6828:
URL: https://github.com/apache/incubator-tvm/pull/6828#discussion_r516522450



##########
File path: tests/python/unittest/test_auto_scheduler_layout_rewrite.py
##########
@@ -166,5 +166,6 @@ def test_correctness_layout_rewrite_insert_transform_stage():
 
 if __name__ == "__main__":
     test_apply_steps_with_layout_rewrite()
-    test_correctness_layout_rewrite_rewrite_for_preTransformed()
-    test_correctness_layout_rewrite_insert_transform_stage()
+    # Disable for now due to being flaky on i386
+    # test_correctness_layout_rewrite_rewrite_for_preTransformed()
+    # test_correctness_layout_rewrite_insert_transform_stage()

Review comment:
       In case this is unstable only on `i386`, is there a possibility to use a `skipif` clause rather than disabling it everywhere?

##########
File path: tutorials/frontend/deploy_object_detection_pytorch.py
##########
@@ -27,16 +27,16 @@
 
 .. code-block:: bash
 
-    pip install torch==1.4.0
-    pip install torchvision==0.5.0
+    pip install torch==1.7.0
+    pip install torchvision==0.8.1
 
 or please refer to official site
 https://pytorch.org/get-started/locally/
 
 PyTorch versions should be backwards compatible but should be used
 with the proper TorchVision version.
 
-Currently, TVM supports PyTorch 1.4 and 1.3. Other versions may
+Currently, TVM supports PyTorch 1.7 and 1.4. Other versions may

Review comment:
       nit: is that ok to claim 1.4 support even if we don't test with it? (please correct me if this doesn't make sense)

##########
File path: tests/python/unittest/test_auto_scheduler_layout_rewrite.py
##########
@@ -166,5 +166,6 @@ def test_correctness_layout_rewrite_insert_transform_stage():
 
 if __name__ == "__main__":
     test_apply_steps_with_layout_rewrite()
-    test_correctness_layout_rewrite_rewrite_for_preTransformed()
-    test_correctness_layout_rewrite_insert_transform_stage()
+    # Disable for now due to being flaky on i386
+    # test_correctness_layout_rewrite_rewrite_for_preTransformed()
+    # test_correctness_layout_rewrite_insert_transform_stage()

Review comment:
       Understood.

##########
File path: tests/python/unittest/test_auto_scheduler_layout_rewrite.py
##########
@@ -166,5 +166,6 @@ def test_correctness_layout_rewrite_insert_transform_stage():
 
 if __name__ == "__main__":
     test_apply_steps_with_layout_rewrite()
-    test_correctness_layout_rewrite_rewrite_for_preTransformed()
-    test_correctness_layout_rewrite_insert_transform_stage()
+    # Disable for now due to being flaky on i386
+    # test_correctness_layout_rewrite_rewrite_for_preTransformed()
+    # test_correctness_layout_rewrite_insert_transform_stage()

Review comment:
       That is #6830 I guess




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] masahi commented on pull request #6828: [CI] Torch 1.7 update to mainline

Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #6828:
URL: https://github.com/apache/incubator-tvm/pull/6828#issuecomment-720874121






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6828: [CI] Torch 1.7 update to mainline

Posted by GitBox <gi...@apache.org>.
jcf94 commented on a change in pull request #6828:
URL: https://github.com/apache/incubator-tvm/pull/6828#discussion_r516534866



##########
File path: tests/python/unittest/test_auto_scheduler_layout_rewrite.py
##########
@@ -166,5 +166,6 @@ def test_correctness_layout_rewrite_insert_transform_stage():
 
 if __name__ == "__main__":
     test_apply_steps_with_layout_rewrite()
-    test_correctness_layout_rewrite_rewrite_for_preTransformed()
-    test_correctness_layout_rewrite_insert_transform_stage()
+    # Disable for now due to being flaky on i386
+    # test_correctness_layout_rewrite_rewrite_for_preTransformed()
+    # test_correctness_layout_rewrite_insert_transform_stage()

Review comment:
       Yes, I'm working on this. :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org