[GitHub] spark pull request: [SPARK-1774] Respect SparkSubmit --jars on YAR...

[uncleGen <gi...@git.apache.org>]

Github user uncleGen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/710#discussion_r17951094
  
    --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -192,15 +236,17 @@ class SparkSubmitSuite extends FunSuite with ShouldMatchers {
       }
     
       test("launch simple application with spark-submit") {
    -    runSparkSubmit(
    -      Seq(
    -        "--class", SimpleApplicationTest.getClass.getName.stripSuffix("$"),
    -        "--name", "testApp",
    -        "--master", "local",
    -        "unUsed.jar"))
    +    val unusedJar = TestUtils.createJarWithClasses(Seq.empty)
    --- End diff --
    
    Here, you mean a jar with empty content? I can not pass this test. But set a class name( i.e. Seq.empty -> Seq("filename") ), it is OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org