You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/11/20 04:58:02 UTC

[GitHub] anirudh2290 commented on a change in pull request #8721: fix custom op for backward compatibility

anirudh2290 commented on a change in pull request #8721: fix custom op for backward compatibility
URL: https://github.com/apache/incubator-mxnet/pull/8721#discussion_r151902607
 
 

 ##########
 File path: tests/python/unittest/test_operator.py
 ##########
 @@ -3652,6 +3652,42 @@ def create_operator(self, ctx, shapes, dtypes):
     assert (x.grad.stype == 'csr')
     assert (y.stype == 'csr')
     assert (aux.stype == 'csr')
+    
+    # test for backward compatibility, i.e. the correctness of default implementation of 
 
 Review comment:
   Please remove whitespaces here and above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services