You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2019/05/14 01:45:00 UTC
[jira] [Commented] (RATIS-547) Refactor RaftLogCache's inner
classes
[ https://issues.apache.org/jira/browse/RATIS-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839006#comment-16839006 ]
Hadoop QA commented on RATIS-547:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 9s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 54s{color} | {color:red} root generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 11s{color} | {color:orange} root: The patch generated 1 new + 8 unchanged - 7 fixed = 9 total (was 15) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 24m 42s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m 54s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.server.TestMetaServer |
| | ratis.logservice.TestLogServiceWithNetty |
| | ratis.examples.filestore.TestFileStoreWithNetty |
| | ratis.examples.filestore.TestFileStoreWithGrpc |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.netty.TestRaftSnapshotWithNetty |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.grpc.TestInstallSnapshotWithGrpc |
| | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.server.TestRaftLogMetrics |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.server.simulation.TestServerRestartWithSimulatedRpc |
| | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.server.storage.TestSegmentedRaftLog |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2019-05-14 |
| JIRA Issue | RATIS-547 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12968615/r547_20190513.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile |
| uname | Linux 1d09ef4dd15c 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build@2/yetus-personality.sh |
| git revision | master / c7b35c3 |
| maven | version: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) |
| Default Java | 1.8.0_191 |
| javac | https://builds.apache.org/job/PreCommit-RATIS-Build/764/artifact/out/diff-compile-javac-root.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-RATIS-Build/764/artifact/out/diff-checkstyle-root.txt |
| unit | https://builds.apache.org/job/PreCommit-RATIS-Build/764/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/764/testReport/ |
| Max. process+thread count | 1468 (vs. ulimit of 5000) |
| modules | C: ratis-common ratis-server ratis-test U: . |
| Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/764/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Refactor RaftLogCache's inner classes
> -------------------------------------
>
> Key: RATIS-547
> URL: https://issues.apache.org/jira/browse/RATIS-547
> Project: Ratis
> Issue Type: Improvement
> Components: server
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Attachments: r547_20190513.patch
>
>
> In RaftLogCache, there are quite a few inner classes which are used in quite many places. Let move some of them out.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)