[jira] Commented: (MYFACES-2100) unnecessary final methods in ApplicationImpl (maybe elsewhere too)

["Simon Lessard (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652437#action_12652437 ] 

Simon Lessard commented on MYFACES-2100:
----------------------------------------

final was added to a lot for method in impl to gain a small speed boost. Event if I'm not sure if I agree with that change, you shouldn't have to extends ApplicationImpl anyway if you leverage the decorator pattern in your ApplicationFactory and create an ApplicationWrapper class overriding only the method you need to and delegating the others. Such architecture would also be much more portable.

> unnecessary final methods in ApplicationImpl (maybe elsewhere too)
> ------------------------------------------------------------------
>
>                 Key: MYFACES-2100
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2100
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 1.2.5
>            Reporter: Paul Pogonyshev
>            Priority: Minor
>
> When trying to upgrade to MyFaces 1.2.5 from 1.1.5 I get several instances of 'overridden method is final' compilation errors for custom subclass of ApplicationImpl.  E.g. I override createConverter() method to post-apply custom setters to results of super.createConverter().
> Are there any good reasons these methods are now final?  Because if this is not fixed (i.e. reverted to previous non-final methods) I will have to reimplement the whole Application class, which sure sucks a lot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.