You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Jorge Condomí (JIRA)" <ji...@apache.org> on 2008/07/04 19:01:32 UTC
[jira] Created: (SHINDIG-427) Content-Rewrite
Content-Rewrite
---------------
Key: SHINDIG-427
URL: https://issues.apache.org/jira/browse/SHINDIG-427
Project: Shindig
Issue Type: New Feature
Components: Gadget Rendering Server (PHP)
Reporter: Jorge Condomí
Add the Content-Rewrite
http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SHINDIG-427) Content-Rewrite
Posted by Kevin Brown <et...@google.com>.
On Tue, Jul 8, 2008 at 8:49 AM, Chris Chabot <ch...@xs4all.nl> wrote:
> If in the container rewrite_by_default = false, and the gadget rewrite
> feature = true, then you rewrite.
>
> The configuration is just to control what to do when the gadget doesn't
> specify anything about rewriting. Orkut style 'rewrite everything if they
> dont specify' or 'don't touch unless requested' :)
Orkut actually switched to opt-in due to all the weird stuff developers were
including in gadgets. I'd recommend most containers do the same unless they
have very close relationships with all the developers targeting them.
>
>
> -- Chris
>
>
> On Jul 8, 2008, at 5:03 PM, Gonzalo Aune wrote:
>
> Chris,
>>
>> what happened if in the container we specified that by default, the
>> content-rewrite is off and you specified it in the gadget xml?, it'll be
>> available right?
>>
>> G.-
>>
>> On Fri, Jul 4, 2008 at 6:07 PM, Chris Chabot (JIRA) <ji...@apache.org>
>> wrote:
>>
>>
>>> [
>>>
>>> https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610663
>>> #action_12610663]
>>>
>>> Chris Chabot commented on SHINDIG-427:
>>> --------------------------------------
>>>
>>> There are 2 test gadgets in
>>> shindig/javascript/samplecontainer/examples/rewriter{on,off}.xml.
>>>
>>> When i try the rewriteron.xml i see that :
>>>
>>> <style type="text/css"> @import url( rewriter1.css ); </style>
>>> is rewritten too:
>>> <style type="text/css"> @import url( rewriter1.css ); </style>
>>>
>>> aka no changes, while it should be rewritten.
>>>
>>> <link rel="stylesheet" type="text/css" href="rewriter2.css"/>
>>> is rewritten too:
>>> <link rel="stylesheet" type="text/css"
>>> href="/gadgets/proxy?url=%2Fgadgets%2Fproxy%3Furl%3Drewriter2.css"/>
>>>
>>> In this case the base URL of the gadget (
>>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/ in my
>>> case) should be prefixed before the URL. However it seems to have changed
>>> it
>>> too /gadgets/proxy?url=rewriter2.css ?
>>>
>>> It should've been:
>>> href="/gadgets/proxy?url=
>>>
>>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter2.css
>>> "
>>>
>>>
>>> In the same spirit:
>>> <img id="rewriteimg" src="feather.png"
>>> is rewritten too:
>>> <img id="rewriteimg"
>>> src="/gadgets/proxy?url=%2Fgadgets%2Fproxy%3Furl%3Dfeather.png"
>>>
>>> but should've been:
>>> src="/gadgets/proxy?url=
>>>
>>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/feather.png
>>> "
>>>
>>> And that goes for the rest of the tags in the rewriteron.xml too.
>>>
>>>
>>> Interestingly enough, in the rewriteroff.xml gadget
>>> <style type="text/css"> @import url(
>>>
>>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter1.css);
>>> </style>
>>> is untouched (as it should be since the gadget has <Param
>>> name="exclude-urls">.*</Param>)
>>>
>>> However:
>>> <link rel="stylesheet" type="text/css" href="
>>>
>>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter2.css
>>> "/>
>>> was turned into:
>>> <link rel="stylesheet" type="text/css"
>>>
>>> href="/gadgets/proxy?url=http%3A%2F%2Fshindig%2Fgadgets%2Ffiles%2Fsamplecontainer%2Fexamples%2Frewriter%2Frewriter2.css"/>
>>>
>>> Which is really interesting, since exclude url's is set to .* aka all !
>>> :)
>>>
>>> Also
>>> <img id="rewriteimg" src="feather.png"
>>> is rewritten (while it shouldn't rewrite anything) to:
>>> <img id="rewriteimg" src="/gadgets/proxy?url=feather.png"
>>>
>>> but
>>> <script type="text/javascript" src="
>>>
>>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter1.js
>>> ">
>>> is un-touched again.
>>>
>>> Seems as it is, the patch isn't ready to be committed yet. Could you
>>> please
>>> take a look at these issues?
>>>
>>> Thanks!
>>>
>>> Content-Rewrite
>>>> ---------------
>>>>
>>>> Key: SHINDIG-427
>>>> URL: https://issues.apache.org/jira/browse/SHINDIG-427
>>>> Project: Shindig
>>>> Issue Type: New Feature
>>>> Components: Gadget Rendering Server (PHP)
>>>> Reporter: Jorge Condomí
>>>> Attachments: content-rewrite-feature.patch
>>>>
>>>>
>>>> Add the Content-Rewrite feature to the Gadget Rendering Servlet and the
>>>>
>>> Proxy servlet
>>>
>>>>
>>>>
>>> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>>
>
Re: [jira] Commented: (SHINDIG-427) Content-Rewrite
Posted by Chris Chabot <ch...@xs4all.nl>.
If in the container rewrite_by_default = false, and the gadget rewrite
feature = true, then you rewrite.
The configuration is just to control what to do when the gadget
doesn't specify anything about rewriting. Orkut style 'rewrite
everything if they dont specify' or 'don't touch unless requested' :)
-- Chris
On Jul 8, 2008, at 5:03 PM, Gonzalo Aune wrote:
> Chris,
>
> what happened if in the container we specified that by default, the
> content-rewrite is off and you specified it in the gadget xml?,
> it'll be
> available right?
>
> G.-
>
> On Fri, Jul 4, 2008 at 6:07 PM, Chris Chabot (JIRA)
> <ji...@apache.org> wrote:
>
>>
>> [
>> https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610663
>> #action_12610663]
>>
>> Chris Chabot commented on SHINDIG-427:
>> --------------------------------------
>>
>> There are 2 test gadgets in
>> shindig/javascript/samplecontainer/examples/rewriter{on,off}.xml.
>>
>> When i try the rewriteron.xml i see that :
>>
>> <style type="text/css"> @import url( rewriter1.css ); </style>
>> is rewritten too:
>> <style type="text/css"> @import url( rewriter1.css ); </style>
>>
>> aka no changes, while it should be rewritten.
>>
>> <link rel="stylesheet" type="text/css" href="rewriter2.css"/>
>> is rewritten too:
>> <link rel="stylesheet" type="text/css"
>> href="/gadgets/proxy?url=%2Fgadgets%2Fproxy%3Furl%3Drewriter2.css"/>
>>
>> In this case the base URL of the gadget (
>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/ in my
>> case) should be prefixed before the URL. However it seems to have
>> changed it
>> too /gadgets/proxy?url=rewriter2.css ?
>>
>> It should've been:
>> href="/gadgets/proxy?url=
>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter2.css
>> "
>>
>>
>> In the same spirit:
>> <img id="rewriteimg" src="feather.png"
>> is rewritten too:
>> <img id="rewriteimg"
>> src="/gadgets/proxy?url=%2Fgadgets%2Fproxy%3Furl%3Dfeather.png"
>>
>> but should've been:
>> src="/gadgets/proxy?url=
>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/feather.png
>> "
>>
>> And that goes for the rest of the tags in the rewriteron.xml too.
>>
>>
>> Interestingly enough, in the rewriteroff.xml gadget
>> <style type="text/css"> @import url(
>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter1.css)
>> ; </style>
>> is untouched (as it should be since the gadget has <Param
>> name="exclude-urls">.*</Param>)
>>
>> However:
>> <link rel="stylesheet" type="text/css" href="
>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter2.css
>> "/>
>> was turned into:
>> <link rel="stylesheet" type="text/css"
>> href="/gadgets/proxy?url=http%3A%2F%2Fshindig%2Fgadgets%2Ffiles
>> %2Fsamplecontainer%2Fexamples%2Frewriter%2Frewriter2.css"/>
>>
>> Which is really interesting, since exclude url's is set to .* aka
>> all ! :)
>>
>> Also
>> <img id="rewriteimg" src="feather.png"
>> is rewritten (while it shouldn't rewrite anything) to:
>> <img id="rewriteimg" src="/gadgets/proxy?url=feather.png"
>>
>> but
>> <script type="text/javascript" src="
>> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter1.js
>> ">
>> is un-touched again.
>>
>> Seems as it is, the patch isn't ready to be committed yet. Could
>> you please
>> take a look at these issues?
>>
>> Thanks!
>>
>>> Content-Rewrite
>>> ---------------
>>>
>>> Key: SHINDIG-427
>>> URL: https://issues.apache.org/jira/browse/
>>> SHINDIG-427
>>> Project: Shindig
>>> Issue Type: New Feature
>>> Components: Gadget Rendering Server (PHP)
>>> Reporter: Jorge Condomí
>>> Attachments: content-rewrite-feature.patch
>>>
>>>
>>> Add the Content-Rewrite feature to the Gadget Rendering Servlet
>>> and the
>> Proxy servlet
>>>
>> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
Re: [jira] Commented: (SHINDIG-427) Content-Rewrite
Posted by Gonzalo Aune <go...@gmail.com>.
Chris,
what happened if in the container we specified that by default, the
content-rewrite is off and you specified it in the gadget xml?, it'll be
available right?
G.-
On Fri, Jul 4, 2008 at 6:07 PM, Chris Chabot (JIRA) <ji...@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610663#action_12610663]
>
> Chris Chabot commented on SHINDIG-427:
> --------------------------------------
>
> There are 2 test gadgets in
> shindig/javascript/samplecontainer/examples/rewriter{on,off}.xml.
>
> When i try the rewriteron.xml i see that :
>
> <style type="text/css"> @import url( rewriter1.css ); </style>
> is rewritten too:
> <style type="text/css"> @import url( rewriter1.css ); </style>
>
> aka no changes, while it should be rewritten.
>
> <link rel="stylesheet" type="text/css" href="rewriter2.css"/>
> is rewritten too:
> <link rel="stylesheet" type="text/css"
> href="/gadgets/proxy?url=%2Fgadgets%2Fproxy%3Furl%3Drewriter2.css"/>
>
> In this case the base URL of the gadget (
> http://shindig/gadgets/files/samplecontainer/examples/rewriter/ in my
> case) should be prefixed before the URL. However it seems to have changed it
> too /gadgets/proxy?url=rewriter2.css ?
>
> It should've been:
> href="/gadgets/proxy?url=
> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter2.css
> "
>
>
> In the same spirit:
> <img id="rewriteimg" src="feather.png"
> is rewritten too:
> <img id="rewriteimg"
> src="/gadgets/proxy?url=%2Fgadgets%2Fproxy%3Furl%3Dfeather.png"
>
> but should've been:
> src="/gadgets/proxy?url=
> http://shindig/gadgets/files/samplecontainer/examples/rewriter/feather.png
> "
>
> And that goes for the rest of the tags in the rewriteron.xml too.
>
>
> Interestingly enough, in the rewriteroff.xml gadget
> <style type="text/css"> @import url(
> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter1.css); </style>
> is untouched (as it should be since the gadget has <Param
> name="exclude-urls">.*</Param>)
>
> However:
> <link rel="stylesheet" type="text/css" href="
> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter2.css
> "/>
> was turned into:
> <link rel="stylesheet" type="text/css"
> href="/gadgets/proxy?url=http%3A%2F%2Fshindig%2Fgadgets%2Ffiles%2Fsamplecontainer%2Fexamples%2Frewriter%2Frewriter2.css"/>
>
> Which is really interesting, since exclude url's is set to .* aka all ! :)
>
> Also
> <img id="rewriteimg" src="feather.png"
> is rewritten (while it shouldn't rewrite anything) to:
> <img id="rewriteimg" src="/gadgets/proxy?url=feather.png"
>
> but
> <script type="text/javascript" src="
> http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter1.js
> ">
> is un-touched again.
>
> Seems as it is, the patch isn't ready to be committed yet. Could you please
> take a look at these issues?
>
> Thanks!
>
> > Content-Rewrite
> > ---------------
> >
> > Key: SHINDIG-427
> > URL: https://issues.apache.org/jira/browse/SHINDIG-427
> > Project: Shindig
> > Issue Type: New Feature
> > Components: Gadget Rendering Server (PHP)
> > Reporter: Jorge Condomí
> > Attachments: content-rewrite-feature.patch
> >
> >
> > Add the Content-Rewrite feature to the Gadget Rendering Servlet and the
> Proxy servlet
> >
> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Updated: (SHINDIG-427) Content-Rewrite
Posted by "Gonzalo Aune (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gonzalo Aune updated SHINDIG-427:
---------------------------------
Attachment: SHINDIG-427-feature.patch
Chris, please validate the patch, the errors you mention were fixed and plus others.
G.-
> Content-Rewrite
> ---------------
>
> Key: SHINDIG-427
> URL: https://issues.apache.org/jira/browse/SHINDIG-427
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Jorge Condomí
> Attachments: content-rewrite-feature.patch, SHINDIG-427-feature.patch
>
>
> Add the Content-Rewrite feature to the Gadget Rendering Servlet and the Proxy servlet
> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-427) Content-Rewrite
Posted by "Jorge Condomí (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jorge Condomí updated SHINDIG-427:
----------------------------------
Description:
Add the Content-Rewrite feature to the Gadget Rendering Servlet and the Proxy servlet
http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
was:
Add the Content-Rewrite
http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
> Content-Rewrite
> ---------------
>
> Key: SHINDIG-427
> URL: https://issues.apache.org/jira/browse/SHINDIG-427
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Jorge Condomí
>
> Add the Content-Rewrite feature to the Gadget Rendering Servlet and the Proxy servlet
> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-427) Content-Rewrite
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610657#action_12610657 ]
Chris Chabot commented on SHINDIG-427:
--------------------------------------
public static $PROXY_URL = "/gadgets/proxy?url=";
With PHP Shindig you can configure under which URL you have shindig installed with the 'web_prefix' param, so when your using some 'hard coded url' you should always do:
$proxyUrl = Config::get('web_prefix).ContentRewriteFeature::$PROXY_URL;
Otherwise it'll break for people who don't have shindig running under / :)
> Content-Rewrite
> ---------------
>
> Key: SHINDIG-427
> URL: https://issues.apache.org/jira/browse/SHINDIG-427
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Jorge Condomí
> Attachments: content-rewrite-feature.patch
>
>
> Add the Content-Rewrite feature to the Gadget Rendering Servlet and the Proxy servlet
> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-427) Content-Rewrite
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610655#action_12610655 ]
Chris Chabot commented on SHINDIG-427:
--------------------------------------
Hey Jorge, thats some great work, patch is looking really good!
A few small things that stood out is that some if blocks were missing {}'s (which leads to subtle bugs in the long run, so we dont do that), and a few small formatting errors, but nothing that wasn't easily fixable.
Also i noticed that in ContentRewriter.php it reads:
$rewriteFeature = $requires [ContentRewriteFeature::$REWRITE_TAG];
if ($rewriteFeature == null) {
return false;
}
Which works great if you have notices turned off, but with notices turned on that creates an error (index not found in the array), so it's better to do:
$requires = $gadget->getRequires();
if (!isset($requires[ContentRewriteFeature::$REWRITE_TAG])) {
return false;
}
That way it does the same, but doesn't generate any errors.
Also from that code i take it that it doesn't rewrite the content unless the content-rewite feature is specified in the gadget xml. Now that's a very reasonable thing to do, but some containers choose to always rewrite unless it's specifically specified not to, like Orkut forinstance:
http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
So i guess the best choice is to make that configurable?
> Content-Rewrite
> ---------------
>
> Key: SHINDIG-427
> URL: https://issues.apache.org/jira/browse/SHINDIG-427
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Jorge Condomí
> Attachments: content-rewrite-feature.patch
>
>
> Add the Content-Rewrite feature to the Gadget Rendering Servlet and the Proxy servlet
> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-427) Content-Rewrite
Posted by "Jorge Condomí (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jorge Condomí updated SHINDIG-427:
----------------------------------
Attachment: content-rewrite-feature.patch
> Content-Rewrite
> ---------------
>
> Key: SHINDIG-427
> URL: https://issues.apache.org/jira/browse/SHINDIG-427
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Jorge Condomí
> Attachments: content-rewrite-feature.patch
>
>
> Add the Content-Rewrite feature to the Gadget Rendering Servlet and the Proxy servlet
> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-427) Content-Rewrite
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610663#action_12610663 ]
Chris Chabot commented on SHINDIG-427:
--------------------------------------
There are 2 test gadgets in shindig/javascript/samplecontainer/examples/rewriter{on,off}.xml.
When i try the rewriteron.xml i see that :
<style type="text/css"> @import url( rewriter1.css ); </style>
is rewritten too:
<style type="text/css"> @import url( rewriter1.css ); </style>
aka no changes, while it should be rewritten.
<link rel="stylesheet" type="text/css" href="rewriter2.css"/>
is rewritten too:
<link rel="stylesheet" type="text/css" href="/gadgets/proxy?url=%2Fgadgets%2Fproxy%3Furl%3Drewriter2.css"/>
In this case the base URL of the gadget (http://shindig/gadgets/files/samplecontainer/examples/rewriter/ in my case) should be prefixed before the URL. However it seems to have changed it too /gadgets/proxy?url=rewriter2.css ?
It should've been:
href="/gadgets/proxy?url=http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter2.css"
In the same spirit:
<img id="rewriteimg" src="feather.png"
is rewritten too:
<img id="rewriteimg" src="/gadgets/proxy?url=%2Fgadgets%2Fproxy%3Furl%3Dfeather.png"
but should've been:
src="/gadgets/proxy?url=http://shindig/gadgets/files/samplecontainer/examples/rewriter/feather.png"
And that goes for the rest of the tags in the rewriteron.xml too.
Interestingly enough, in the rewriteroff.xml gadget
<style type="text/css"> @import url( http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter1.css ); </style>
is untouched (as it should be since the gadget has <Param name="exclude-urls">.*</Param>)
However:
<link rel="stylesheet" type="text/css" href="http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter2.css"/>
was turned into:
<link rel="stylesheet" type="text/css" href="/gadgets/proxy?url=http%3A%2F%2Fshindig%2Fgadgets%2Ffiles%2Fsamplecontainer%2Fexamples%2Frewriter%2Frewriter2.css"/>
Which is really interesting, since exclude url's is set to .* aka all ! :)
Also
<img id="rewriteimg" src="feather.png"
is rewritten (while it shouldn't rewrite anything) to:
<img id="rewriteimg" src="/gadgets/proxy?url=feather.png"
but
<script type="text/javascript" src="http://shindig/gadgets/files/samplecontainer/examples/rewriter/rewriter1.js">
is un-touched again.
Seems as it is, the patch isn't ready to be committed yet. Could you please take a look at these issues?
Thanks!
> Content-Rewrite
> ---------------
>
> Key: SHINDIG-427
> URL: https://issues.apache.org/jira/browse/SHINDIG-427
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Jorge Condomí
> Attachments: content-rewrite-feature.patch
>
>
> Add the Content-Rewrite feature to the Gadget Rendering Servlet and the Proxy servlet
> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-427) Content-Rewrite
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot resolved SHINDIG-427.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
This patch went in a week or 2 ago, closing the issue
> Content-Rewrite
> ---------------
>
> Key: SHINDIG-427
> URL: https://issues.apache.org/jira/browse/SHINDIG-427
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Jorge Condomí
> Assignee: Chris Chabot
> Attachments: SHINDIG-427-feature.patch
>
>
> Add the Content-Rewrite feature to the Gadget Rendering Servlet and the Proxy servlet
> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-427) Content-Rewrite
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610656#action_12610656 ]
Chris Chabot commented on SHINDIG-427:
--------------------------------------
Trying the examples in shindig/javascript/samplecontainer/examples/rewriter, i see a few more notice's:
Notice: Undefined index: include-urls in /Users/chabotc/shindig/php/src/gadgets/rewrite/ContentRewriteFeature.php on line 41
Notice: Undefined index: include-tags in /Users/chabotc/shindig/php/src/gadgets/rewrite/ContentRewriteFeature.php on line 43
It's a good habit to use if (isset($array[$key])) everywhere :)
> Content-Rewrite
> ---------------
>
> Key: SHINDIG-427
> URL: https://issues.apache.org/jira/browse/SHINDIG-427
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Jorge Condomí
> Attachments: content-rewrite-feature.patch
>
>
> Add the Content-Rewrite feature to the Gadget Rendering Servlet and the Proxy servlet
> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-427) Content-Rewrite
Posted by "Jorge Condomí (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jorge Condomí updated SHINDIG-427:
----------------------------------
Attachment: (was: content-rewrite-feature.patch)
> Content-Rewrite
> ---------------
>
> Key: SHINDIG-427
> URL: https://issues.apache.org/jira/browse/SHINDIG-427
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Jorge Condomí
> Attachments: SHINDIG-427-feature.patch
>
>
> Add the Content-Rewrite feature to the Gadget Rendering Servlet and the Proxy servlet
> http://orkutdeveloper.blogspot.com/2008/06/rewriting-returns-to-sandbox.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.