You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2018/01/04 14:57:08 UTC

[GitHub] nifi pull request #2138: NIFI-4371 - add support for query timeout in Hive p...

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2138#discussion_r159670913
  
    --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveQL.java ---
    @@ -233,6 +234,7 @@ private FunctionContext(boolean rollbackOnFailure, Charset charset, String state
                         }
     
                         // Execute the statement
    +                    stmt.setQueryTimeout(context.getProperty(QUERY_TIMEOUT).evaluateAttributeExpressions(flowFile).asInteger());
    --- End diff --
    
    If the driver doesn't support this (at least for Apache Hive 1.2.1), it will throw an exception, perhaps wrap these calls in a try/catch and ignore any errors (as they would have been presented to the user via doc and validation)?


---