You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/28 10:03:26 UTC

[GitHub] [spark] lsm1 opened a new pull request, #37014: [SPARK-39624] [SQL] Support coalesce partition through CartesianProduct

lsm1 opened a new pull request, #37014:
URL: https://github.com/apache/spark/pull/37014

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   Coalesce paritition for every group
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   With CartesianProduct, CoalesceShufflePartitions can not optimize it and the result partition would be left partition * right partition which can be quite lagre.
   ![image](https://user-images.githubusercontent.com/18713676/176088198-33d89672-6ffe-4382-84a6-0c6b116e8ea1.png)
   
   It's better to support partial optimize with CartesianProductExec.
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   The result partition might changed.
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   Add test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a diff in pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #37014:
URL: https://github.com/apache/spark/pull/37014#discussion_r913391359


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2602,6 +2602,59 @@ class AdaptiveQueryExecSuite
       assert(findTopLevelBroadcastNestedLoopJoin(adaptivePlan).size == 1)
     }
   }
+
+  test("SPARK-39624 Support coalesce partition through CartesianProduct") {
+    def checkResultPartition(df: Dataset[Row],
+                             numShuffleReader: Int,
+                             numPartition: Int): Unit = {

Review Comment:
   ```suggestion
       def checkResultPartition(
           df: Dataset[Row],
           numShuffleReader: Int,
           numPartition: Int): Unit = {
   ```



##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2602,6 +2602,59 @@ class AdaptiveQueryExecSuite
       assert(findTopLevelBroadcastNestedLoopJoin(adaptivePlan).size == 1)
     }
   }
+
+  test("SPARK-39624 Support coalesce partition through CartesianProduct") {
+    def checkResultPartition(df: Dataset[Row],
+                             numShuffleReader: Int,
+                             numPartition: Int): Unit = {
+      df.collect()
+      print(df.queryExecution.executedPlan)

Review Comment:
   can we remove print



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a diff in pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37014:
URL: https://github.com/apache/spark/pull/37014#discussion_r916504512


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2602,6 +2602,59 @@ class AdaptiveQueryExecSuite
       assert(findTopLevelBroadcastNestedLoopJoin(adaptivePlan).size == 1)
     }
   }
+
+  test("SPARK-39624 Support coalesce partition through CartesianProduct") {
+    def checkResultPartition(
+       df: Dataset[Row],
+       numShuffleReader: Int,
+       numPartition: Int): Unit = {
+      df.collect()
+      assert(collect(df.queryExecution.executedPlan) {
+        case r: AQEShuffleReadExec => r
+      }.size === numShuffleReader)
+      assert(df.rdd.partitions.length === numPartition)
+    }
+    withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+      SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "true",
+      SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES.key -> "1048576",
+      SQLConf.COALESCE_PARTITIONS_MIN_PARTITION_NUM.key -> "1",
+      SQLConf.SHUFFLE_PARTITIONS.key -> "10") {
+      withTempView("t1", "t2", "t3") {
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 2)
+          .toDF().createOrReplaceTempView("t1")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t2")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t3")
+        // positive test that could be coalesced
+        checkResultPartition(
+          sql("""
+                |SELECT * FROM
+                |(SELECT * FROM t3) t3

Review Comment:
   why can't we use `t3` directly?



##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2602,6 +2602,59 @@ class AdaptiveQueryExecSuite
       assert(findTopLevelBroadcastNestedLoopJoin(adaptivePlan).size == 1)
     }
   }
+
+  test("SPARK-39624 Support coalesce partition through CartesianProduct") {
+    def checkResultPartition(
+       df: Dataset[Row],
+       numShuffleReader: Int,
+       numPartition: Int): Unit = {
+      df.collect()
+      assert(collect(df.queryExecution.executedPlan) {
+        case r: AQEShuffleReadExec => r
+      }.size === numShuffleReader)
+      assert(df.rdd.partitions.length === numPartition)
+    }
+    withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+      SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "true",
+      SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES.key -> "1048576",
+      SQLConf.COALESCE_PARTITIONS_MIN_PARTITION_NUM.key -> "1",
+      SQLConf.SHUFFLE_PARTITIONS.key -> "10") {
+      withTempView("t1", "t2", "t3") {
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 2)
+          .toDF().createOrReplaceTempView("t1")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t2")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t3")
+        // positive test that could be coalesced
+        checkResultPartition(
+          sql("""
+                |SELECT * FROM
+                |(SELECT * FROM t3) t3
+                |join (
+                |SELECT t1.key, t2.value FROM
+                |(SELECT * FROM t1 ) t1

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] github-actions[bot] closed pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct
URL: https://github.com/apache/spark/pull/37014


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] lsm1 commented on a diff in pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
lsm1 commented on code in PR #37014:
URL: https://github.com/apache/spark/pull/37014#discussion_r916414485


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2602,6 +2602,59 @@ class AdaptiveQueryExecSuite
       assert(findTopLevelBroadcastNestedLoopJoin(adaptivePlan).size == 1)
     }
   }
+
+  test("SPARK-39624 Support coalesce partition through CartesianProduct") {
+    def checkResultPartition(
+       df: Dataset[Row],
+       numShuffleReader: Int,
+       numPartition: Int): Unit = {
+      df.collect()
+      assert(collect(df.queryExecution.executedPlan) {
+        case r: AQEShuffleReadExec => r
+      }.size === numShuffleReader)
+      assert(df.rdd.partitions.length === numPartition)
+    }
+    withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+      SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "true",
+      SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES.key -> "1048576",
+      SQLConf.COALESCE_PARTITIONS_MIN_PARTITION_NUM.key -> "1",
+      SQLConf.SHUFFLE_PARTITIONS.key -> "10") {
+      withTempView("t1", "t2", "t3") {
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 2)
+          .toDF().createOrReplaceTempView("t1")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t2")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t3")
+        // positive test that could be coalesced

Review Comment:
   Like Union operation, if children of CartesianProduct can be coalesce partition, the rule will effect, otherwrise not effect



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maryannxue commented on a diff in pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
maryannxue commented on code in PR #37014:
URL: https://github.com/apache/spark/pull/37014#discussion_r913956638


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/CoalesceShufflePartitions.scala:
##########
@@ -132,6 +133,7 @@ case class CoalesceShufflePartitions(session: SparkSession) extends AQEShuffleRe
       Seq(collectShuffleStageInfos(r))
     case unary: UnaryExecNode => collectCoalesceGroups(unary.child)
     case union: UnionExec => union.children.flatMap(collectCoalesceGroups)
+    case cartesian: CartesianProductExec => cartesian.children.flatMap(collectCoalesceGroups)

Review Comment:
   update the javadoc for this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ulysses-you commented on pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #37014:
URL: https://github.com/apache/spark/pull/37014#issuecomment-1178450350

   +1 with @maryannxue comment. Otherwise the idea looks good, also cc @cloud-fan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maryannxue commented on a diff in pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
maryannxue commented on code in PR #37014:
URL: https://github.com/apache/spark/pull/37014#discussion_r913956001


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2602,6 +2602,59 @@ class AdaptiveQueryExecSuite
       assert(findTopLevelBroadcastNestedLoopJoin(adaptivePlan).size == 1)
     }
   }
+
+  test("SPARK-39624 Support coalesce partition through CartesianProduct") {
+    def checkResultPartition(
+       df: Dataset[Row],
+       numShuffleReader: Int,
+       numPartition: Int): Unit = {
+      df.collect()
+      assert(collect(df.queryExecution.executedPlan) {
+        case r: AQEShuffleReadExec => r
+      }.size === numShuffleReader)
+      assert(df.rdd.partitions.length === numPartition)
+    }
+    withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+      SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "true",
+      SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES.key -> "1048576",
+      SQLConf.COALESCE_PARTITIONS_MIN_PARTITION_NUM.key -> "1",
+      SQLConf.SHUFFLE_PARTITIONS.key -> "10") {
+      withTempView("t1", "t2", "t3") {
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 2)
+          .toDF().createOrReplaceTempView("t1")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t2")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t3")
+        // positive test that could be coalesced

Review Comment:
   can you explain a little more in the code comment why a query `can` (not could) be coalesced or why it can't?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a diff in pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37014:
URL: https://github.com/apache/spark/pull/37014#discussion_r916505114


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2602,6 +2602,59 @@ class AdaptiveQueryExecSuite
       assert(findTopLevelBroadcastNestedLoopJoin(adaptivePlan).size == 1)
     }
   }
+
+  test("SPARK-39624 Support coalesce partition through CartesianProduct") {
+    def checkResultPartition(
+       df: Dataset[Row],
+       numShuffleReader: Int,
+       numPartition: Int): Unit = {
+      df.collect()
+      assert(collect(df.queryExecution.executedPlan) {
+        case r: AQEShuffleReadExec => r
+      }.size === numShuffleReader)
+      assert(df.rdd.partitions.length === numPartition)
+    }
+    withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+      SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "true",
+      SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES.key -> "1048576",
+      SQLConf.COALESCE_PARTITIONS_MIN_PARTITION_NUM.key -> "1",
+      SQLConf.SHUFFLE_PARTITIONS.key -> "10") {
+      withTempView("t1", "t2", "t3") {
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 2)
+          .toDF().createOrReplaceTempView("t1")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t2")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t3")
+        // positive test that could be coalesced
+        checkResultPartition(
+          sql("""
+                |SELECT * FROM
+                |(SELECT * FROM t3) t3
+                |join (
+                |SELECT t1.key, t2.value FROM
+                |(SELECT * FROM t1 ) t1
+                |join (SELECT * FROM t2) t2
+                |on t1.value = t2.value) t
+                |on t3.key = t.key or t3.value=t.value
+            """.stripMargin),
+          numShuffleReader = 2,
+          numPartition = 4)
+        // negative test
+        checkResultPartition(
+          sql("""
+                |SELECT * FROM
+                |(SELECT * FROM t1)
+                |t1 join (SELECT * FROM t2)
+                |t2 on t1.key = t2.key
+                |or t1.value=t2.value

Review Comment:
   Why doesn't this trigger a partition coalesce? isn't it a cartesian product?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a diff in pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37014:
URL: https://github.com/apache/spark/pull/37014#discussion_r916577151


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2602,6 +2602,56 @@ class AdaptiveQueryExecSuite
       assert(findTopLevelBroadcastNestedLoopJoin(adaptivePlan).size == 1)
     }
   }
+
+  test("SPARK-39624 Support coalesce partition through CartesianProduct") {
+    def checkResultPartition(
+       df: Dataset[Row],
+       numShuffleReader: Int,
+       numPartition: Int): Unit = {
+      df.collect()
+      assert(collect(df.queryExecution.executedPlan) {
+        case r: AQEShuffleReadExec => r
+      }.size === numShuffleReader)
+      assert(df.rdd.partitions.length === numPartition)
+    }
+    withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+      SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "true",
+      SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES.key -> "1048576",
+      SQLConf.COALESCE_PARTITIONS_MIN_PARTITION_NUM.key -> "1",
+      SQLConf.SHUFFLE_PARTITIONS.key -> "10") {
+      withTempView("t1", "t2", "t3") {
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 2)
+          .toDF().createOrReplaceTempView("t1")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t2")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t3")
+        // positive test that could be coalesced
+        checkResultPartition(
+          sql("""
+                |SELECT * FROM
+                |t3 join (
+                |SELECT t1.key, t2.value FROM
+                |t1 join t2
+                |on t1.value = t2.value) t
+                |on t3.key = t.key or t3.value=t.value
+            """.stripMargin),
+          numShuffleReader = 2,
+          numPartition = 4)
+        // negative test

Review Comment:
   let's say more: `// negative test: children of cartesian product do not have shuffles`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] github-actions[bot] commented on pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #37014:
URL: https://github.com/apache/spark/pull/37014#issuecomment-1327938485

   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maryannxue commented on pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
maryannxue commented on PR #37014:
URL: https://github.com/apache/spark/pull/37014#issuecomment-1175224895

   Can you please rework your PR description, by stating what's the behavior before and after your change? That screenshot doesn't say anything here. You can remove it. Maybe use some before/after examples instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] lsm1 commented on a diff in pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
lsm1 commented on code in PR #37014:
URL: https://github.com/apache/spark/pull/37014#discussion_r916551528


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2602,6 +2602,59 @@ class AdaptiveQueryExecSuite
       assert(findTopLevelBroadcastNestedLoopJoin(adaptivePlan).size == 1)
     }
   }
+
+  test("SPARK-39624 Support coalesce partition through CartesianProduct") {
+    def checkResultPartition(
+       df: Dataset[Row],
+       numShuffleReader: Int,
+       numPartition: Int): Unit = {
+      df.collect()
+      assert(collect(df.queryExecution.executedPlan) {
+        case r: AQEShuffleReadExec => r
+      }.size === numShuffleReader)
+      assert(df.rdd.partitions.length === numPartition)
+    }
+    withSQLConf(SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+      SQLConf.COALESCE_PARTITIONS_ENABLED.key -> "true",
+      SQLConf.ADVISORY_PARTITION_SIZE_IN_BYTES.key -> "1048576",
+      SQLConf.COALESCE_PARTITIONS_MIN_PARTITION_NUM.key -> "1",
+      SQLConf.SHUFFLE_PARTITIONS.key -> "10") {
+      withTempView("t1", "t2", "t3") {
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 2)
+          .toDF().createOrReplaceTempView("t1")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t2")
+        spark.sparkContext.parallelize((1 to 10).map(i => TestData(i, i.toString)), 4)
+          .toDF().createOrReplaceTempView("t3")
+        // positive test that could be coalesced
+        checkResultPartition(
+          sql("""
+                |SELECT * FROM
+                |(SELECT * FROM t3) t3
+                |join (
+                |SELECT t1.key, t2.value FROM
+                |(SELECT * FROM t1 ) t1
+                |join (SELECT * FROM t2) t2
+                |on t1.value = t2.value) t
+                |on t3.key = t.key or t3.value=t.value
+            """.stripMargin),
+          numShuffleReader = 2,
+          numPartition = 4)
+        // negative test
+        checkResultPartition(
+          sql("""
+                |SELECT * FROM
+                |(SELECT * FROM t1)
+                |t1 join (SELECT * FROM t2)
+                |t2 on t1.key = t2.key
+                |or t1.value=t2.value

Review Comment:
   It's a cartesian product, but the children plan does not contain `ShuffleQueryStage`, so the rule not effect 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a diff in pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37014:
URL: https://github.com/apache/spark/pull/37014#discussion_r916576320


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2602,6 +2602,56 @@ class AdaptiveQueryExecSuite
       assert(findTopLevelBroadcastNestedLoopJoin(adaptivePlan).size == 1)
     }
   }
+
+  test("SPARK-39624 Support coalesce partition through CartesianProduct") {
+    def checkResultPartition(
+       df: Dataset[Row],

Review Comment:
   nit: 4 spaces indentation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #37014: [SPARK-39624][SQL] Support coalesce partition through CartesianProduct

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37014:
URL: https://github.com/apache/spark/pull/37014#issuecomment-1169011900

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org