You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/12 12:41:47 UTC

[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #4189: Fix clippy by avoiding deprecated functions in chrono

jackwener commented on code in PR #4189:
URL: https://github.com/apache/arrow-datafusion/pull/4189#discussion_r1020756617


##########
datafusion/common/src/scalar.rs:
##########
@@ -572,7 +572,12 @@ fn do_date_time_math(
     scalar: &ScalarValue,
     sign: i32,
 ) -> Result<NaiveDateTime> {
-    let prior = NaiveDateTime::from_timestamp(secs, nsecs);
+    let prior = NaiveDateTime::from_timestamp_opt(secs, nsecs).ok_or_else(|| {

Review Comment:
   Not sure if this is the problem elsewhere, we can file an issue tracker



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org