You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/20 16:32:53 UTC
[GitHub] [doris] xinyiZzz opened a new pull request, #15217: [fix](memory) Fix too many repeat cause OOM
xinyiZzz opened a new pull request, #15217:
URL: https://github.com/apache/doris/pull/15217
# Proposed changes
Issue Number: close #xxx
## Problem summary
Limit the maximum number of repeat
```
select repeat("a", 10000);
```
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15217: [fix](memory) Fix too many repeat cause OOM
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15217:
URL: https://github.com/apache/doris/pull/15217#issuecomment-1362262707
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15217: [fix](memory) Fix too many repeat cause OOM
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15217:
URL: https://github.com/apache/doris/pull/15217#issuecomment-1359857853
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.21 seconds
load time: 643 seconds
storage size: 17122875466 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221220172516_clickbench_pr_65839.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15217: [fix](memory) Fix too many repeat cause OOM
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15217:
URL: https://github.com/apache/doris/pull/15217#issuecomment-1361305178
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #15217: [fix](memory) Fix too many repeat cause OOM
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #15217:
URL: https://github.com/apache/doris/pull/15217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15217: [fix](memory) Fix too many repeat cause OOM
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15217:
URL: https://github.com/apache/doris/pull/15217#issuecomment-1359692872
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15217: [fix](memory) Fix too many repeat cause OOM
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15217:
URL: https://github.com/apache/doris/pull/15217#issuecomment-1361006546
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15217: [fix](memory) Fix too many repeat cause OOM
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15217:
URL: https://github.com/apache/doris/pull/15217#issuecomment-1361504740
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #15217: [fix](memory) Fix too many repeat cause OOM
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on PR #15217:
URL: https://github.com/apache/doris/pull/15217#issuecomment-1380174035
> This pr sets the repeat count to the smaller value of count and `repeat_max_num`, which may cause the result to be inconsistent with the user's expectations and there is no error prompt. Why not throw an exception when count is greater than `repeat_max_num`?
throw an exception seems to be a better solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on pull request #15217: [fix](memory) Fix too many repeat cause OOM
Posted by GitBox <gi...@apache.org>.
luozenglin commented on PR #15217:
URL: https://github.com/apache/doris/pull/15217#issuecomment-1364659317
This pr sets the repeat count to the smaller value of count and `repeat_max_num`, which may cause the result to be inconsistent with the user's expectations and there is no error prompt. Why not throw an exception when count is greater than `repeat_max_num`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org