Re: Review Request 22066: Added timeout to rescind unused offers

[Adam B <ad...@mesosphere.io>]

> On May 31, 2014, 8:47 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [22066]
> > 
> > Failed command: git apply --index 22066.patch
> > 
> > Error:
> >  error: patch failed: src/master/flags.hpp:229
> > error: src/master/flags.hpp: patch does not apply
> > 22066.patch:139: new blank line at EOF.
> > +
> >

Just needs a rebase, since Flags::acls was commented out.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22066/#review44460
-----------------------------------------------------------


On May 29, 2014, 4:22 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22066/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 4:22 p.m.)
> 
> 
> Review request for mesos, Adam B and Niklas Nielsen.
> 
> 
> Bugs: mesos-186
>     https://issues.apache.org/jira/browse/mesos-186
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> A timer is associated with each newly created offer.
> The offer is rescinded on timeout.
> The timer is disarmed on a launchTask or decline.
> 
> 
> Diffs
> -----
> 
>   src/master/flags.hpp e890227 
>   src/master/master.hpp d4ef4be 
>   src/master/master.cpp 766a0e3 
>   src/tests/master_tests.cpp 7183cb7 
> 
> Diff: https://reviews.apache.org/r/22066/diff/
> 
> 
> Testing
> -------
> 
> Added MasterTest.RescindResourceOffers and ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>