You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "markap14 (via GitHub)" <gi...@apache.org> on 2026/02/17 21:03:41 UTC
[PR] NIFI-15615: Ensure that we include necessary values in the ConnectorS… [nifi]
markap14 opened a new pull request, #10913:
URL: https://github.com/apache/nifi/pull/10913
…tatusDTO
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
- [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15615: Ensure that we include necessary values in the ConnectorS… [nifi]
Posted by "bbende (via GitHub)" <gi...@apache.org>.
bbende commented on code in PR #10913:
URL: https://github.com/apache/nifi/pull/10913#discussion_r2822981979
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -5275,6 +5278,61 @@ public ConnectorDTO createConnectorDto(final ConnectorNode connector) {
return dto;
}
+ public ConnectorStatusDTO createConnectorStatusDto(final ConnectorNode connectorNode, final ProcessGroupStatus managedGroupStatus) {
+ if (connectorNode == null) {
+ return null;
+ }
+
+ final ConnectorStatusDTO statusDto = new ConnectorStatusDTO();
+ statusDto.setId(connectorNode.getIdentifier());
+ statusDto.setName(connectorNode.getName());
+ statusDto.setType(connectorNode.getCanonicalClassName());
+ statusDto.setRunStatus(connectorNode.getCurrentState().name());
+ statusDto.setValidationStatus(connectorNode.getValidationStatus().name());
+ statusDto.setStatsLastRefreshed(new Date());
+
+ final ConnectorStatusSnapshotDTO snapshot = new ConnectorStatusSnapshotDTO();
Review Comment:
Should `statusDto` and `snapshot` both call `setGroupId` ?
There are other places like in `StatusMerger` or the `clone` method where it does consider the groupId. Not that it would NPE, but seems like it was expecting it to be populated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15615: Ensure that we include necessary values in the ConnectorS… [nifi]
Posted by "bbende (via GitHub)" <gi...@apache.org>.
bbende merged PR #10913:
URL: https://github.com/apache/nifi/pull/10913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-15615: Ensure that we include necessary values in the ConnectorS… [nifi]
Posted by "bbende (via GitHub)" <gi...@apache.org>.
bbende commented on code in PR #10913:
URL: https://github.com/apache/nifi/pull/10913#discussion_r2823071553
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java:
##########
@@ -5275,6 +5278,61 @@ public ConnectorDTO createConnectorDto(final ConnectorNode connector) {
return dto;
}
+ public ConnectorStatusDTO createConnectorStatusDto(final ConnectorNode connectorNode, final ProcessGroupStatus managedGroupStatus) {
+ if (connectorNode == null) {
+ return null;
+ }
+
+ final ConnectorStatusDTO statusDto = new ConnectorStatusDTO();
+ statusDto.setId(connectorNode.getIdentifier());
+ statusDto.setName(connectorNode.getName());
+ statusDto.setType(connectorNode.getCanonicalClassName());
+ statusDto.setRunStatus(connectorNode.getCurrentState().name());
+ statusDto.setValidationStatus(connectorNode.getValidationStatus().name());
+ statusDto.setStatsLastRefreshed(new Date());
+
+ final ConnectorStatusSnapshotDTO snapshot = new ConnectorStatusSnapshotDTO();
Review Comment:
Discussed offline and it is not necessary to set groupId since this is the top level Connector status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org