You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2018/03/06 07:47:34 UTC
[Bug 62160] New: Property values linking
https://bz.apache.org/bugzilla/show_bug.cgi?id=62160
Bug ID: 62160
Summary: Property values linking
Product: Tomcat 9
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Util
Assignee: dev@tomcat.apache.org
Reporter: remm@apache.org
Target Milestone: -----
Created attachment 35752
--> https://bz.apache.org/bugzilla/attachment.cgi?id=35752&action=edit
Loop over value replacement until done
I got a request to add property "links" which do like the following:
some.host=${remote.hostname}:${remote.port}
remote.hostname=foo.bar.com
remote.port=8080
Although I don't consider this a very good idea, it might have its uses. To
implement it, I am considering adding loops around resolving the
${propertyName} [see patch].
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62160] Property values linking
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62160
Remy Maucherat <re...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Remy Maucherat <re...@apache.org> ---
After playing it a bit, it looked better to me. The update will be in 9.0.7 and
8.5.30, unless someone complains about it.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62160] Property values linking
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62160
Remy Maucherat <re...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WONTFIX
Status|REOPENED |RESOLVED
--- Comment #3 from Remy Maucherat <re...@apache.org> ---
I have reverted my patch and will leave it at that since I do not agree with
the reasoning or your expected result.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62160] Property values linking
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62160
Konstantin Kolinko <kn...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--- Comment #2 from Konstantin Kolinko <kn...@gmail.com> ---
I am OK with the feature, but I am -1 on the approach implemented in this patch
(r1825989).
1). Consider the following properties:
first=${
second=bar}
bar=baz
If you have value="${first}${second}" my expectation is that result of
substitution will be value="${bar}". Your algorithm will yield value="baz".
I think the replacement loop should be inside of
IntrospectionUtils.replaceProperties(),
looking for replacements in the value of a property.
Instead of looping over resulting value.
2). It would be better to have some hard limit on recursion depth. E.g. 20.
(Not a showstopper requirement, but a "nice to have" one).
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org