You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sigma-Ma (via GitHub)" <gi...@apache.org> on 2026/10/10 10:34:12 UTC

[PR] HBASE-30452 Exclude JUnit libraries from shaded testing util [hbase]

Sigma-Ma opened a new pull request, #8755:
URL: https://github.com/apache/hbase/pull/8755

   JIRA: https://issues.apache.org/jira/browse/HBASE-30452.
   
   ## What changes were proposed in this pull request?
   
   Exclude JUnit and its support libraries from hbase-shaded-testing-util, and add a test for the shaded JAR contents. Keep HBase's JUnit 4 compatibility shim.
   
   ## Why are the changes needed?
   
   The 2.6.7 JAR embeds older JUnit Jupiter and Platform classes. They can be loaded ahead of a downstream project's JUnit 6 classes and break test discovery.
   
   ## How was this patch tested?
   
   ```bash
   mvn -pl hbase-shaded/hbase-shaded-testing-util-tester -am -Dtest=TestShadedTestingUtilJarContents -Dsurefire.skipSecondPart=true package
   
   mvn -pl hbase-shaded/hbase-shaded-testing-util-tester -am -Dtest=TestShadedHBaseTestingUtility -Dsurefire.firstPartGroups=org.apache.hadoop.hbase.testclassification.MediumTests -Dsurefire.skipSecondPart=true package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30452 Exclude JUnit libraries from shaded testing util [hbase]

Posted by "Sigma-Ma (via GitHub)" <gi...@apache.org>.
Sigma-Ma commented on PR #8755:
URL: https://github.com/apache/hbase/pull/8755#issuecomment-6168418005

   > Please also open a PR against branch-2?
   > 
   > Thanks.
   
   Branch-2 backport: https://github.com/apache/hbase/pull/8769. Both the shaded JAR content check and the mini-cluster test pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30452 Exclude JUnit libraries from shaded testing util [hbase]

Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #8755:
URL: https://github.com/apache/hbase/pull/8755#issuecomment-6166356654

   OK, so on branch-3+ we already have this problem before HBASE-30200 and we introduce this problem to branch-2.x in HBASE-30200.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30452 Exclude JUnit libraries from shaded testing util [hbase]

Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #8755:
URL: https://github.com/apache/hbase/pull/8755#issuecomment-6098392580

   So why there is no problem before 2.6.7? We do not have these exclusion in the past I believe?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30452 Exclude JUnit libraries from shaded testing util [hbase]

Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 merged PR #8755:
URL: https://github.com/apache/hbase/pull/8755


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30452 Exclude JUnit libraries from shaded testing util [hbase]

Posted by "Sigma-Ma (via GitHub)" <gi...@apache.org>.
Sigma-Ma commented on PR #8755:
URL: https://github.com/apache/hbase/pull/8755#issuecomment-6116515015

   > So why there is no problem before 2.6.7? We do not have these exclusion in the past I believe?
   
   Hi Apache9, In 2.6.6, the Jupiter dependencies in hbase-testing-util were test-scoped, so they were not transitive dependencies of hbase-shaded-testing-util. [HBASE-30200](https://github.com/apache/hbase/commit/4e1301f9e9b735cdfd09817ace04a09c670735e9) changed them to compile scope before 2.6.7, causing Shade to bundle them. The exclusion list itself did not change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30452 Exclude JUnit libraries from shaded testing util [hbase]

Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on PR #8755:
URL: https://github.com/apache/hbase/pull/8755#issuecomment-6177649108

   Thanks @pjfanning and @Sigma-Ma!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30452 Exclude JUnit libraries from shaded testing util [hbase]

Posted by "Apache9 (via GitHub)" <gi...@apache.org>.
Apache9 commented on PR #8755:
URL: https://github.com/apache/hbase/pull/8755#issuecomment-6166368345

   Please also open a PR against branch-2?
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] HBASE-30452 Exclude JUnit libraries from shaded testing util [hbase]

Posted by "Sigma-Ma (via GitHub)" <gi...@apache.org>.
Sigma-Ma commented on PR #8755:
URL: https://github.com/apache/hbase/pull/8755#issuecomment-6168015787

   > Please also open a PR against branch-2?
   > 
   > Thanks.
   
   Thanks for the review, @Apache9. I'll open a PR against branch-2 as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org