You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/12 14:32:11 UTC
[GitHub] [pulsar] nicoloboschi opened a new issue, #17595: [Bug] Entry filters stats should not be increased if there's no entry filter
nicoloboschi opened a new issue, #17595:
URL: https://github.com/apache/pulsar/issues/17595
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### Version
2.10.1
### Minimal reproduce step
```
pulsar-admin produce -m hello mytopic
pulsar-admin consume -s sub1 -p Earliest mytopic
pulsar-admin stats mytopic
```
The result is
```
...
"filterProcessedMsgCount" : 1,
"filterAcceptedMsgCount" : 1,
"filterRejectedMsgCount" : 0,
"filterRescheduledMsgCount" : 0,
....
```
### What did you expect to see?
I do expect that if no entry filter has been used by the dispatcher, the `filterProcessedMsgCount` and `filterAcceptedMsgCount` metrics should not be increased.
### What did you see instead?
The metrics are updated even if there's no entry filter configured
### Anything else?
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on issue #17595: [Bug] Entry filters stats should not be increased if there's no entry filter
Posted by GitBox <gi...@apache.org>.
tjiuming commented on issue #17595:
URL: https://github.com/apache/pulsar/issues/17595#issuecomment-1244867686
assign me plz, I'll fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on issue #17595: [Bug] Entry filters stats should not be increased if there's no entry filter
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on issue #17595:
URL: https://github.com/apache/pulsar/issues/17595#issuecomment-1243834964
@tjiuming is this intended? https://github.com/apache/pulsar/pull/16932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on issue #17595: [Bug] Entry filters stats should not be increased if there's no entry filter
Posted by GitBox <gi...@apache.org>.
tjiuming commented on issue #17595:
URL: https://github.com/apache/pulsar/issues/17595#issuecomment-1244899833
A new PR created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyuanpeng commented on issue #17595: [Bug] Entry filters stats should not be increased if there's no entry filter
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on issue #17595:
URL: https://github.com/apache/pulsar/issues/17595#issuecomment-1243927423
IMO, It might be better if the relevant metrics show -1 without entryFilter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi closed issue #17595: [Bug] Entry filters stats should not be increased if there's no entry filter
Posted by GitBox <gi...@apache.org>.
nicoloboschi closed issue #17595: [Bug] Entry filters stats should not be increased if there's no entry filter
URL: https://github.com/apache/pulsar/issues/17595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #17595: [Bug] Entry filters stats should not be increased if there's no entry filter
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #17595:
URL: https://github.com/apache/pulsar/issues/17595#issuecomment-1254473931
> I do expect that if no entry filter has been used by the dispatcher, the `filterProcessedMsgCount` and `filterAcceptedMsgCount` metrics should not be increased.
I am a bit late on this issue, but one comment is that the naming on that metric is ambiguous and could have been meaningful in the previous design. For example, we filter out certain entries that are system messages even when there are not entry filters. Perhaps we should make sure not to count system messages in the `filterProcessedMsgCount` counter to prevent them from skewing the numbers for the filter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org